Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Use latest js-ipfs and go-ipfs#44

Merged
daviddias merged 1 commit intomasterfrom
new-releases
Nov 4, 2018
Merged

Use latest js-ipfs and go-ipfs#44
daviddias merged 1 commit intomasterfrom
new-releases

Conversation

@daviddias
Copy link
Member

@daviddias daviddias commented Nov 3, 2018

No description provided.

@ghost ghost assigned daviddias Nov 3, 2018
@ghost ghost added the status/in-progress In progress label Nov 3, 2018
daviddias
daviddias commented Nov 3, 2018
View reviewed changes
test/exchange-files.js

const timeout = 240 * 1000

describe.skip('exchange files', () => {
Copy link
Member Author

@daviddias daviddias Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these disabled????! 👀

Copy link
Member

@vasco-santos vasco-santos Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this PR interop#42

Copy link
Member Author

@daviddias daviddias Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to assign P0 to things like these. Two big releases for go-ipfs and js-ipfs were made without testing these at all.

Copy link
Member

@vasco-santos vasco-santos Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Created an issue for tracking it ipfs/interop#45.

@daviddias daviddias force-pushed the new-releases branch 3 times, most recently from 56d649c to 4bc1a8f Compare November 3, 2018 09:36
daviddias
daviddias commented Nov 3, 2018
View reviewed changes
test/exchange-files.js
// 10 * GB,
// 100 * GB,
// 1000 * GB
]
Copy link
Member Author

@daviddias daviddias Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugomrdias you have here some pretty solids tests for KR

@daviddias
Copy link
Member Author

daviddias commented Nov 3, 2018 •
edited
Loading

I've added a go -> go test so that we can compare both implementations.

image
(click the image)

Rest of the results:

» npm run test:node -- --grep="exchange files"

> interop-ipfs@0.0.0 test:node /Users/imp/code/interop
> cross-env IPFS_REUSEPORT=false aegir test -t node -f test/node.js "--grep=exchange files"

superagent: Enable experimental feature http2
Test Node.js
superagent: Enable experimental feature http2


  exchange files
    ✓ connect go <-> js (69ms)
    ✓ connect go <-> go2
    ✓ connect js <-> js2 (47ms)
    cat file
      ✓ go -> js: 1.02 kB (285ms)
      ✓ js -> go: 1.02 kB (194ms)
      ✓ js -> js2: 1.02 kB (452ms)
      ✓ go -> go2: 1.02 kB
      ✓ go -> js: 63.5 kB (253ms)
      ✓ js -> go: 63.5 kB (186ms)
      ✓ js -> js2: 63.5 kB (399ms)
      ✓ go -> go2: 63.5 kB
      ✓ go -> js: 65.5 kB (259ms)
      ✓ js -> go: 65.5 kB (200ms)
      ✓ js -> js2: 65.5 kB (416ms)
      ✓ go -> go2: 65.5 kB
      ✓ go -> js: 524 kB (528ms)
      ✓ js -> go: 524 kB (356ms)
      ✓ js -> js2: 524 kB (781ms)
      ✓ go -> go2: 524 kB (41ms)
      ✓ go -> js: 786 kB (559ms)
      ✓ js -> go: 786 kB (369ms)
      ✓ js -> js2: 786 kB (829ms)
      ✓ go -> go2: 786 kB (62ms)
      ✓ go -> js: 1.05 MB (561ms)
      ✓ js -> go: 1.05 MB (409ms)
      ✓ js -> js2: 1.05 MB (842ms)
      ✓ go -> go2: 1.05 MB (70ms)
      ✓ go -> js: 1.05 MB (568ms)
      ✓ js -> go: 1.05 MB (412ms)
      ✓ js -> js2: 1.05 MB (889ms)
      ✓ go -> go2: 1.05 MB (72ms)
      ✓ go -> js: 4.19 MB (906ms)
      ✓ js -> go: 4.19 MB (1013ms)
      ✓ js -> js2: 4.19 MB (1248ms)
      ✓ go -> go2: 4.19 MB (226ms)
      ✓ go -> js: 8.39 MB (1442ms)
      ✓ js -> go: 8.39 MB (1709ms)
      ✓ js -> js2: 8.39 MB (1786ms)
      ✓ go -> go2: 8.39 MB (372ms)
      ✓ go -> js: 67.1 MB (6761ms)
      ✓ js -> go: 67.1 MB (12765ms)
      ✓ js -> js2: 67.1 MB (10125ms)
      ✓ go -> go2: 67.1 MB (3298ms)
      ✓ go -> js: 134 MB (13261ms)
      ✓ js -> go: 134 MB (25563ms)
      ✓ js -> js2: 134 MB (20542ms)
      ✓ go -> go2: 134 MB (8291ms)
      ✓ go -> js: 537 MB (47154ms)
      ✓ js -> go: 537 MB (113647ms)
      ✓ js -> js2: 537 MB (81874ms)
      ✓ go -> go2: 537 MB (26844ms)

I've also made the Directory tests more interesting (with more depth)

  get directory
      ✓ go -> js: depth: 5, num: 5 (335ms)
      ✓ js -> go: depth: 5, num: 5 (349ms)
      ✓ js -> js: depth: 5, num: 5 (708ms)
      ✓ go -> js: depth: 5, num: 10 (320ms)
      ✓ js -> go: depth: 5, num: 10 (694ms)
      ✓ js -> js: depth: 5, num: 10 (856ms)
      ✓ go -> js: depth: 5, num: 50 (590ms)
      ✓ js -> go: depth: 5, num: 50 (2490ms)
      ✓ js -> js: depth: 5, num: 50 (2854ms)
      ✓ go -> js: depth: 10, num: 5 (327ms)
      ✓ js -> go: depth: 10, num: 5 (796ms)
      ✓ js -> js: depth: 10, num: 5 (941ms)
      ✓ go -> js: depth: 10, num: 10 (392ms)
      ✓ js -> go: depth: 10, num: 10 (1032ms)
      ✓ js -> js: depth: 10, num: 10 (1459ms)
      ✓ go -> js: depth: 10, num: 50 (686ms)
      ✓ js -> go: depth: 10, num: 50 (4032ms)
      ✓ js -> js: depth: 10, num: 50 (4222ms)

daviddias
daviddias commented Nov 3, 2018
View reviewed changes
test/exchange-files.js Outdated
// TODO these tests are not fetching the full dir??
describe('get directory', () => dirs.forEach((num) => {
it(`go -> js: depth: 5, num: ${num}`, function () {
// TODO Why aren't these tests fetching the full directory and comparing it??
Copy link
Member Author

@daviddias daviddias Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whyyyyy??!?

Copy link
Member Author

@daviddias daviddias Nov 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

@daviddias daviddias mentioned this pull request Nov 3, 2018
Closed
@daviddias
Copy link
Member Author

daviddias commented Nov 3, 2018

Seems that Jenkins is completely dead. I can't even enter https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Finterop/activity

@ipfs/infrastructure do you know what's up?

@daviddias
Copy link
Member Author

daviddias commented Nov 3, 2018

btw, all of the tests as they are right now:
image

@daviddias daviddias force-pushed the new-releases branch 4 times, most recently from 58abe9f to dd02e38 Compare November 4, 2018 14:04
@daviddias
Copy link
Member Author

daviddias commented Nov 4, 2018

All tests passing except for the MacOS who got its disk filled
image

Report ipfs-inactive/dev-team-enablement#163

@daviddias daviddias merged commit 4085089 into master Nov 4, 2018
@daviddias daviddias deleted the new-releases branch November 4, 2018 17:27
@ghost ghost removed the status/in-progress In progress label Nov 4, 2018
This was referenced Nov 4, 2018
Closed
Closed
@daviddias daviddias mentioned this pull request Jan 25, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

@alanshaw alanshaw Awaiting requested review from alanshaw

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

1 more reviewer

@vasco-santos vasco-santos vasco-santos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@daviddias daviddias

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daviddias @vasco-santos