[#217,#218] Remove Python 2 support code, implement proper thread state handling (4-3-stable)#220
Conversation
SwooshyCueb
force-pushed
the
218.4-3-stable
branch
2 times, most recently
from
890b570 to
47b50cf
Compare
|
Ran the test suites for Ubuntu 22.04 and 24.04 and everything passed, so I'm marking this ready for review. Will squash and update the other PR tomorrow. |
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
I defer to others. Had a couple of suggestions but looks fine overall. Glad it's working
|
After some discussion, the plan is to see if testing passes for Ubuntu 20 before testing non-Ubuntu platforms. If the tests pass for all platforms, then Ubuntu 24 and the PREP get a 4.3.3 release. |
SwooshyCueb
force-pushed
the
218.4-3-stable
branch
from
84f981a to
f0fc9dd
Compare
|
Tests pass for Ubuntu 20.04. Commits squashed. If there are no objections, I will #. |
|
Let's test the remaining platforms first just in case other tweaks are needed. I'll pull your changes and start running tests. |
SwooshyCueb
changed the title
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Looks good overall.
Once the review comments have been addressed, I think we'll be ready to get this in.
Good stuff.
SwooshyCueb
force-pushed
the
218.4-3-stable
branch
from
f0fc9dd to
09e57f6
Compare
|
Because I don't suspect anything to break, but we need to be sure. |
It still passes. Tested on Ubuntu 24.04 and 20.04. |
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Excellent. Code is good/ready.
Please add words to the body of the commit message for #218 which explain what is being solved.
SwooshyCueb
force-pushed
the
218.4-3-stable
branch
from
09e57f6 to
33e7ab6
Compare
Done |
With Python 3.12, we started seeing crashes during certain multithreaded operations. It turns out that changes to the GIL in 3.12 exposed that we are not handling Python thread state properly. This commit fixes this. A new namespace python_state has been added to main.cpp for holding onto some Python state information, and a new struct python_thread_state_scope has also been added for managing Python thread state. This will be improved upon in the future.
SwooshyCueb
force-pushed
the
218.4-3-stable
branch
from
33e7ab6 to
94fbb04
Compare
|
#'d |
3 participants
Addresses #217
Addresses #218 (WIP)
Not tested yet, could probably be improved.
Since I am currently testing with 4-3-stable, progress may be followed here instead of in #219.