Adds release version to benchmark output

[kellyguo11]

Description

Adds the Isaac Lab release version (from the root VERSION file) to the benchmark output files.

Motivation

The VersionInfoRecorder currently collects package versions via importlib.metadata (pip) and module __version__ attributes. These reflect what is installed in the current environment, but do not capture the release version of Isaac Lab itself (e.g. 3.0.0 from the root VERSION file).

This makes it hard to correlate benchmark results with specific releases, especially when the installed pip version does not match the source tree (e.g. editable installs during development).

Changes

• source/isaaclab/isaaclab/test/benchmark/recorders/record_version_info.py:
  • Added reading of the top-level VERSION file → recorded as isaaclab_release

Example Output

Before (existing fields preserved):

isaaclab: 4.5.25
isaaclab_tasks: 1.5.15

After (new field added):

isaaclab_release: 3.0.0        # ← from VERSION file

Testing

Verified the recorder produces correct output with the expected field populated. No existing fields are modified — this is purely additive.

[greptile-apps]

Greptile Summary

This PR adds the Isaac Lab release version (from the root VERSION file) and per-sub-package extension.toml versions to the VersionInfoRecorder benchmark output. The implementation inlines both additions into _get_version_info() (note: the PR description mentions a separate _get_release_version() method that does not appear in the final code), wraps all I/O in try/except for graceful degradation, and correctly computes _REPO_ROOT as 6 levels up from the recorder file. CHANGELOG and version bump (4.5.27) are consistent across both CHANGELOG.rst and extension.toml.

Confidence Score: 4/5

Mostly safe to merge, but the bare import tomllib at module-level will raise ModuleNotFoundError on Python 3.10, which is within the declared python_requires=">=3.10" range.

The prior review threads already flagged the tomllib/tomli import strategy. The current code removed the tomli fallback but left a plain import tomllib, which is stdlib only from Python 3.11. Since setup.py declares python_requires=">=3.10", this remains an unresolved P1-level compatibility gap. All other changes (VERSION file read, source/ dir iteration, CHANGELOG, version bump) are correct and robust.

source/isaaclab/isaaclab/test/benchmark/recorders/record_version_info.py — top-level import tomllib incompatible with Python 3.10.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename	Overview
source/isaaclab/isaaclab/test/benchmark/recorders/record_version_info.py	Adds VERSION file and extension.toml version collection; uses top-level import tomllib (Python 3.11+ only) with no fallback, while setup.py sets python_requires=">=3.10", breaking module import on Python 3.10.
source/isaaclab/docs/CHANGELOG.rst	New 4.5.27 version entry added with correct date, category, and RST formatting; consistent with extension.toml bump.
source/isaaclab/config/extension.toml	Version bumped to 4.5.27 matching the new CHANGELOG entry; no other changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[VersionInfoRecorder.__init__] --> B[_get_version_info]
    B --> C[Module imports and importlib.metadata]
    B --> D[Open root VERSION file]
    B --> E[Iterate source subdirectories]
    E --> F[_get_ext_version for each package]
    F --> G{tomllib.load binary mode}
    G -->|success| H[record entry_ext key]
    G -->|exception| I[return None and skip]
    D -->|success| J[record isaaclab_release]
    D -->|exception| I
    C --> K[record isaaclab, warp, torch, etc.]
    H --> L[_version_info dict]
    J --> L
    K --> L
    L --> M[get_data converts to StringMetadata list]

Loading

_{Reviews (2): Last reviewed commit: "Add changelog entry and bump version to ..." | Re-trigger Greptile}

[greptile-apps]

Unguarded tomli fallback crashes module import

If running Python < 3.11 and tomli is not installed (it is not declared in any dependency manifest — setup.py, pyproject.toml, or config/extension.toml), the bare import tomli as tomllib raises ModuleNotFoundError at module load time. This makes the entire record_version_info module unimportable, silently disabling all benchmark recording — not just the new version fields. The toml package is already a declared required dependency and parses the same format; a nested try/except using it as a final fallback would fix this.

Suggested change

	try:
	import tomllib
	except ModuleNotFoundError:
	import tomli as tomllib # Python < 3.11
	try:
	import tomllib
	except ModuleNotFoundError:
	try:
	import tomli as tomllib # Python < 3.11 with tomli installed
	except ModuleNotFoundError:
	import toml as tomllib # type: ignore[no-redef] # fallback: already-required dep

Note: toml.load() requires a text-mode file handle, while tomllib.load() requires binary mode. If using the toml fallback you will also need to conditionally change the open(toml_path, "rb") call on line 86 to text mode, or restructure _get_release_version to detect which library is active.

[greptile-apps]

New undeclared optional dependency

The tomli package is not listed in setup.py, pyproject.toml, or config/extension.toml. Project guidelines explicitly say to avoid new optional dependencies when existing ones suffice. Since toml is already required everywhere in this package (it is used in setup.py itself to read extension.toml), it can replace tomli here without adding any new dependency.

[AntoineRichard]

I feel like this could be better structured.

[AntoineRichard]

We should be using python3.11 at minimum. So none of this is needed.

[AntoineRichard]

Remove and import tomllib only.

[AntoineRichard]

Why not use get_version directly?

I.e.

if os.path.isdir(source_dir):
            for entry in sorted(os.listdir(source_dir)):
                version = get_version(entry)
                if version:
                    self._record(f"{entry}_ext", version

[AntoineRichard]

Also could this not be done in _get_version_info directly?

[AntoineRichard]

@greptile

[greptile-apps]

Tip:

Greploops — Automatically fix all review issues by running /greploops in Claude Code. It iterates: fix, push, re-review, repeat until 5/5 confidence.

Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal.

[isaaclab-review-bot]

LGTM — clean, additive change.

What it does: Reads the top-level VERSION file (e.g. 3.0.0) at benchmark time and records it as isaaclab_release. This fills the gap where pip metadata versions reflect the installed environment but not the actual release tag of the source tree.

Review notes:

• _REPO_ROOT path traversal (6 levels up) is correct for source/isaaclab/isaaclab/test/benchmark/recorders/ → repo root ✅
• Bare except Exception: pass is consistent with the file's existing defensive style (all version reads silently degrade) ✅
• Purely additive — no existing benchmark output fields are modified, so backward compatibility is preserved ✅
• Changelog and version bump look good ✅

Minor nit (non-blocking): _get_git_info() still computes its own script_dir = os.path.dirname(os.path.abspath(__file__)) on L112. Could reuse _REPO_ROOT as cwd for the subprocess.run calls there too, but that's cosmetic — the git commands work from any directory in the repo.

Note: The PR title mentions "extension.toml versions" but those were removed in the latest commit — might want to update the title to just "Add release version to benchmark output" to match the current scope.

updated