Skip to content

Fixes typo correction for IsaacSim Docker Version#5209

Merged
kellyguo11 merged 4 commits into
isaac-sim:developfrom
thdhyan:develop
Apr 8, 2026
Merged

Fixes typo correction for IsaacSim Docker Version#5209
kellyguo11 merged 4 commits into
isaac-sim:developfrom
thdhyan:develop

Conversation

@thdhyan
Copy link
Copy Markdown

@thdhyan thdhyan commented Apr 8, 2026

Description

The ISAACSIM_VERSION was mispelled as ISAACSSIM_VERISON. Leading to failure in docker workflow and build process . Correction in variable in .env.base

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 8, 2026

Greptile Summary

This PR fixes a typo in docker/.env.base where the environment variable was misspelled as ISAACSSIM_VERISON instead of ISAACSIM_VERSION, which was causing Docker workflow and build failures. The contributor's name is also added to CONTRIBUTORS.md, though it is inserted slightly out of alphabetical order.

Confidence Score: 5/5

Safe to merge — the fix is correct and the only remaining finding is a minor alphabetical ordering issue in CONTRIBUTORS.md.

The core change (typo fix in .env.base) is straightforward and correct. The single P2 finding (out-of-order contributor name) is a trivial style issue that does not block merge per the confidence guidelines.

CONTRIBUTORS.md — entry for Dhyan Thakkar needs to swap with Dhananjay Shendre to restore alphabetical order.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
docker/.env.base Corrects the misspelled variable name from ISAACSSIM_VERISON to ISAACSIM_VERSION, which was causing Docker build failures.
CONTRIBUTORS.md Adds Dhyan Thakkar to the Contributors list, but the entry is placed out of alphabetical order — it appears before Dhananjay Shendre when it should follow it.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[docker/.env.base] -->|ISAACSIM_VERSION=6.0.0-dev2| B[docker-compose.yaml]
    B -->|ISAACSIM_VERSION_ARG| C[Dockerfile.base]
    B -->|ISAACSIM_VERSION_ARG| D[Dockerfile.curobo]
    C -->|FROM base image:version| E[Docker Build]
    D -->|FROM base image:version| E
Loading

Reviews (1): Last reviewed commit: "Add name to Contributors" | Re-trigger Greptile

Comment thread docker/.env.base Outdated
Comment thread CONTRIBUTORS.md Outdated
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
@kellyguo11 kellyguo11 changed the title Typo correction for IsaacSim Docker Version Fixes typo correction for IsaacSim Docker Version Apr 8, 2026
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Dhyan Umeshkumar Thakkar <thakk100@umn.edu>
Copy link
Copy Markdown

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ Good catch — ISAACSSIM_VERSIONISAACSIM_VERSION fixes the env var name to match what the rest of the Docker/build tooling expects (docker-compose.yaml, Dockerfile.base, isaaclab.sh, CI workflows, etc.). Without this fix the version variable would silently resolve to empty in Docker builds.

Contributors list addition looks correct (alphabetical order maintained).

@thdhyan
Copy link
Copy Markdown
Author

thdhyan commented Apr 8, 2026

Thanks for approval @kellyguo11.

@kellyguo11 kellyguo11 merged commit 6a881cf into isaac-sim:develop Apr 8, 2026
1 check passed
mmichelis pushed a commit to mmichelis/IsaacLab that referenced this pull request Apr 10, 2026
# Description

<!--
Thank you for your interest in sending a pull request. Please make sure
to check the contribution guidelines.

Link:
https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html

💡 Please try to keep PRs small and focused. Large PRs are harder to
review and merge.
-->

The ISAACSIM_VERSION was mispelled as ISAACSSIM_VERISON. Leading to
failure in docker workflow and build process . Correction in variable in
.env.base

Fixes # (issue)

<!-- As a practice, it is recommended to open an issue to have
discussions on the proposed pull request.
This makes it easier for the community to keep track of what is being
developed or added, and if a given feature
is demanded by more than one party. -->

## Type of change

<!-- As you go through the list, delete the ones that are not
applicable. -->

- Bug fix (non-breaking change which fixes an issue)

## Screenshots

Please attach before and after screenshots of the change if applicable.

<!--
Example:

| Before | After |
| ------ | ----- |
| _gif/png before_ | _gif/png after_ |

To upload images to a PR -- simply drag and drop an image while in edit
mode and it should upload the image directly. You can then paste that
source into the above before/after sections.
-->

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->

---------

Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Signed-off-by: Dhyan Umeshkumar Thakkar <thakk100@umn.edu>
Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants