Fixes typo correction for IsaacSim Docker Version#5209
Conversation
Greptile SummaryThis PR fixes a typo in Confidence Score: 5/5Safe to merge — the fix is correct and the only remaining finding is a minor alphabetical ordering issue in CONTRIBUTORS.md. The core change (typo fix in CONTRIBUTORS.md — entry for Dhyan Thakkar needs to swap with Dhananjay Shendre to restore alphabetical order.
|
| Filename | Overview |
|---|---|
| docker/.env.base | Corrects the misspelled variable name from ISAACSSIM_VERISON to ISAACSIM_VERSION, which was causing Docker build failures. |
| CONTRIBUTORS.md | Adds Dhyan Thakkar to the Contributors list, but the entry is placed out of alphabetical order — it appears before Dhananjay Shendre when it should follow it. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[docker/.env.base] -->|ISAACSIM_VERSION=6.0.0-dev2| B[docker-compose.yaml]
B -->|ISAACSIM_VERSION_ARG| C[Dockerfile.base]
B -->|ISAACSIM_VERSION_ARG| D[Dockerfile.curobo]
C -->|FROM base image:version| E[Docker Build]
D -->|FROM base image:version| E
Reviews (1): Last reviewed commit: "Add name to Contributors" | Re-trigger Greptile
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Dhyan Umeshkumar Thakkar <thakk100@umn.edu>
There was a problem hiding this comment.
LGTM ✅ Good catch — ISAACSSIM_VERSION → ISAACSIM_VERSION fixes the env var name to match what the rest of the Docker/build tooling expects (docker-compose.yaml, Dockerfile.base, isaaclab.sh, CI workflows, etc.). Without this fix the version variable would silently resolve to empty in Docker builds.
Contributors list addition looks correct (alphabetical order maintained).
|
Thanks for approval @kellyguo11. |
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html 💡 Please try to keep PRs small and focused. Large PRs are harder to review and merge. --> The ISAACSIM_VERSION was mispelled as ISAACSSIM_VERISON. Leading to failure in docker workflow and build process . Correction in variable in .env.base Fixes # (issue) <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Screenshots Please attach before and after screenshots of the change if applicable. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: Kelly Guo <kellyg@nvidia.com> Signed-off-by: Dhyan Umeshkumar Thakkar <thakk100@umn.edu> Co-authored-by: Kelly Guo <kellyg@nvidia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Description
The ISAACSIM_VERSION was mispelled as ISAACSSIM_VERISON. Leading to failure in docker workflow and build process . Correction in variable in .env.base
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there