Skip to content

Pins Isaac Sim image to previous image from 05/11#5600

Merged
kellyguo11 merged 2 commits into
isaac-sim:developfrom
kellyguo11:test-ci-0512
May 13, 2026
Merged

Pins Isaac Sim image to previous image from 05/11#5600
kellyguo11 merged 2 commits into
isaac-sim:developfrom
kellyguo11:test-ci-0512

Conversation

@kellyguo11
Copy link
Copy Markdown
Contributor

@kellyguo11 kellyguo11 commented May 13, 2026

Description

Reverts CI image to previous Isaac Sim image from 05/11 as the new image is causing timeouts in our CI.
TODO: investigate failing cause of the new image.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 requested a review from hhansen-bdai as a code owner May 13, 2026 00:24
@kellyguo11 kellyguo11 marked this pull request as draft May 13, 2026 00:24
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR stabilises CI by pinning the Isaac Sim image to the known-good 05/11 digest instead of the floating latest-develop tag, and raises the test_articulation.py timeout to account for any added latency with the pinned image.

  • .github/workflows/config.yaml: isaacsim_image_tag changes from latest-develop to latest-develop@sha256:0dd49a1121b297dc85eee7777a9c528318683dbe03b29fd01f2059ac1b099301, locking all CI workflows to the 05/11 build.
  • tools/test_settings.py: test_articulation.py per-test timeout is doubled from 1500 s to 3000 s, preventing spurious timeout failures under the pinned image.

Confidence Score: 5/5

Safe to merge — both changes are minimal, targeted CI configuration fixes with no impact on production code.

The image digest pin is a well-understood stabilisation technique that makes CI deterministic, and the timeout increase is a conservative adjustment to prevent spurious failures. Neither change touches application logic or test correctness.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/config.yaml Pins the Isaac Sim CI image from the floating latest-develop tag to a specific digest from 05/11, preventing CI from picking up a broken upstream image.
tools/test_settings.py Doubles the timeout for test_articulation.py from 1500 s to 3000 s, likely compensating for slower execution observed with the pinned image.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI Workflow triggered] --> B[Load config.yaml via yq]
    B --> C{Image tag}
    C -->|Before: latest-develop| D[Pull latest upstream image\n⚠️ may pick up broken image]
    C -->|After: latest-develop@sha256:...| E[Pull pinned 05/11 digest\n✅ stable, reproducible]
    E --> F[Run tests]
    F --> G{test_articulation.py}
    G -->|Before: 1500s timeout| H[May time out on slower image]
    G -->|After: 3000s timeout| I[Sufficient headroom for pinned image]
Loading

Reviews (2): Last reviewed commit: "increase timeout" | Re-trigger Greptile

# workflow via yq and exposed as job outputs (see e.g. .github/workflows/build.yaml).
isaacsim_image_name: nvcr.io/nvidian/isaac-sim
isaacsim_image_tag: latest-develop
isaacsim_image_tag: latest-develop@sha256:0dd49a1121b297dc85eee7777a9c528318683dbe03b29fd01f2059ac1b099301
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Temporary pin needs a follow-up tracking item

This digest pin is a good short-term fix, but the PR description and checklist are largely unfilled, making it easy to forget to revert or update the pin once the upstream latest-develop image is healthy again. Consider opening a follow-up issue (or leaving a # TODO: comment referencing the upstream issue) so the floating tag is restored and CI doesn't silently drift further behind the current image over time.

@kellyguo11 kellyguo11 marked this pull request as ready for review May 13, 2026 04:25
@kellyguo11 kellyguo11 merged commit d58e3d7 into isaac-sim:develop May 13, 2026
22 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant