Skip to content

Pins Isaac Sim image to previous image from 05/11 #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellyguo11 merged 2 commits into from
May 13, 2026
Merged

Pins Isaac Sim image to previous image from 05/11 #5600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd8a782
Pins Isaac Sim image to previous image from 05/11
kellyguo11 May 13, 2026
cc992b2
increase timeout
kellyguo11 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
# Shared image config for CI workflows. Loaded by the `config` job in each
# workflow via yq and exposed as job outputs (see e.g. .github/workflows/build.yaml).
isaacsim_image_name: nvcr.io/nvidian/isaac-sim
isaacsim_image_tag: latest-develop
isaacsim_image_tag: latest-develop@sha256:0dd49a1121b297dc85eee7777a9c528318683dbe03b29fd01f2059ac1b099301
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Temporary pin needs a follow-up tracking item

This digest pin is a good short-term fix, but the PR description and checklist are largely unfilled, making it easy to forget to revert or update the pin once the upstream latest-develop image is healthy again. Consider opening a follow-up issue (or leaving a # TODO: comment referencing the upstream issue) so the floating tag is restored and CI doesn't silently drift further behind the current image over time.

isaaclab_image_name: nvcr.io/nvidian/isaac-lab
2 changes: 1 addition & 1 deletion tools/test_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


PER_TEST_TIMEOUTS = {
"test_articulation.py": 1500,
"test_articulation.py": 3000,
"test_stage_in_memory.py": 1000,
"test_imu.py": 1000,
"test_environments.py": 10000, # This test runs through all the environments for 100 steps each
Expand Down
Loading