[Newton] Bump Newton pin to v1.2.0rc3#5614
Conversation
Greptile SummaryThis PR bumps the Newton dependency pin from
Confidence Score: 5/5Safe to merge — all five Newton pin sites are updated consistently to v1.2.0rc3 using the correct newton[sim] git-URL form. The change is purely mechanical version-string replacements across five files, with no IsaacLab-side code changes. All pin sites use the same git-URL and [sim] extra, changelog entries are present and accurate, and the PR description thoroughly explains the history and motivation. No files require special attention. The wheel_builder TOML and all three setup.py files are in sync. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["newton[sim] @ git+...@v1.2.0rc3"]
A --> B["isaaclab_newton/setup.py - all extra"]
A --> C["isaaclab_physx/setup.py - newton extra"]
A --> D["isaaclab_visualizers/setup.py - newton extra"]
A --> E["isaaclab_visualizers/setup.py - rerun extra"]
A --> F["isaaclab_visualizers/setup.py - viser extra"]
A --> G["tools/wheel_builder/res/python_packages.toml"]
A --> H["mujoco-warp 3.8.0.2 - transitive via newton[sim]"]
H --> I["No IsaacLab-side pin change needed"]
Reviews (1): Last reviewed commit: "Bump Newton pin to v1.2.0rc3" | Re-trigger Greptile |
35eb9e9 to
2e4db1e
Compare
There was a problem hiding this comment.
🤖 Automated Code Review — PR #5614
Summary
This PR bumps the Newton physics engine pin from v1.2.0rc2 to v1.2.0rc3 across all 5 declaration sites, maintaining the canonical newton[sim] @ git+... form. This is a version-string-only change with no IsaacLab code modifications.
✅ Review Status
All checks pass. The changelog fragment naming issue from the initial commit was resolved in the follow-up commit.
📦 Dependency Changes
| File | Change |
|---|---|
isaaclab_newton/setup.py |
v1.2.0rc2 → v1.2.0rc3 |
isaaclab_physx/setup.py |
v1.2.0rc2 → v1.2.0rc3 |
isaaclab_visualizers/setup.py |
v1.2.0rc2 → v1.2.0rc3 (3 extras: newton, rerun, viser) |
tools/wheel_builder/res/python_packages.toml |
v1.2.0rc2 → v1.2.0rc3 |
Transitive dependency: mjwarp upgrades from 3.8.0.1 → 3.8.0.2 via newton[sim].
✅ Architecture Review
| Aspect | Status | Notes |
|---|---|---|
| Pin Consistency | ✅ Pass | All 5 Newton pin locations updated consistently |
[sim] Extra Preserved |
✅ Pass | Correctly maintains newton[sim] @ git+... form |
| Changelog Fragments | ✅ Pass | Properly added with dot-free slug naming |
| Cross-module Sync | ✅ Pass | PhysX [newton] extra matches isaaclab_newton pin |
⚠️ Behavioral Change Awareness
The PR description correctly documents upstream rc3 changes that may affect simulation behavior:
- MPR/GJK convex-hull centering (newton#2651) — Contact computation for off-center convex meshes now handles non-origin-centered hulls correctly
- SolverMuJoCo fixes — Planar mesh handling, contact-anchor computation, and distance conversion improvements
- Kamino FK performance (newton#2703) — Forward kinematics solver optimizations
- HDR tiled camera (newton#2721) — HDR color output support for tiled camera sensors
These are upstream improvements, but scenes relying on previous (incorrect) behavior for off-center convex meshes may need adjustment. The author appropriately flags this in the caveat section.
📋 CI Status
- ✅ Build Wheel
- ✅ Check changelog fragments
- ✅ Check for Broken Links
- ✅ Installation Tests
- ✅ Pre-commit
- ⏳ License check (pending)
- ⏳ Docker builds (pending)
📝 Final Assessment
Verdict: Ready to merge once pending CI checks complete.
This is a clean dependency version bump with:
- Consistent pin updates across all declaration sites
- Proper
[sim]extra preservation (avoiding the #5024 regression) - Complete changelog documentation
- Clear communication of behavioral change risks
No IsaacLab code changes required — the upstream fixes flow through cleanly.
Update (019ec00): ✅ Reviewed incremental changes. The new commits add comprehensive changelog fragments for all affected packages (isaaclab, isaaclab_newton, isaaclab_physx, isaaclab_visualizers) with proper dot-free slug naming. Documentation is thorough, including upstream PR links and transitive mjwarp bump details. No new concerns — LGTM.
Update (3803363): ✅ Force-push squashed prior commits into a single clean commit. No functional changes from previous review — same version bumps and changelog fragments. LGTM.
019ec00 to
a0c213e
Compare
Restores the bump that was briefly active between isaac-sim#5024 and isaac-sim#5566, keeping the canonical `newton[sim] @ git+...` form across all five pin sites (isaaclab_newton, isaaclab_physx, isaaclab_visualizers x3, tools/wheel_builder/res/python_packages.toml). mjwarp moves 3.8.0.1 -> 3.8.0.2 transitively via newton[sim] -- no IsaacLab-side mujoco / mujoco-warp pin change since isaac-sim#5566 dropped explicit pins.
a0c213e to
3803363
Compare
## Summary Bumps the Newton pin from `v1.2.0rc2` (current develop) directly to the [`v1.2.0` stable release](https://github.com/newton-physics/newton/releases/tag/v1.2.0) across all five pin sites, keeping the canonical `newton[sim] @ git+...` form everywhere. Per Kelly Guo's suggestion: skip the rc bump and go straight to stable. Upstream published `v1.2.0` on 2026-05-12. **Alternative**: [#5614](#5614) (rc3 bump) — pick whichever target based on CI signal. This one is the most forward target. > Branch is still named `jichuanh/newton-1.2.0rc4-bump` from when this PR was originally proposing rc4 — the branch name doesn't match the current target but the diff is correct. Force-pushing the rename would close/reopen the PR, which adds noise without changing the artifact. ## What's new in Newton v1.2.0 vs v1.2.0rc2 Full release notes: [newton-physics/newton release v1.2.0](https://github.com/newton-physics/newton/releases/tag/v1.2.0). Notable IsaacLab-relevant fixes: - [newton-physics/newton#2651](newton-physics/newton#2651) — MPR/GJK no longer assumes convex hulls are centered around the origin. - [newton-physics/newton#2703](newton-physics/newton#2703) — Kamino FK solver performance. - [newton-physics/newton#2721](newton-physics/newton#2721) — HDR color output for tiled camera sensors. - [newton-physics/newton#2743](newton-physics/newton#2743) — Collada textures in URDF import. - [newton-physics/newton#2823](newton-physics/newton#2823) — Gravity-data device allocation in Kamino (multi-GPU). - [newton-physics/newton#2632](newton-physics/newton#2632) — CollisionPipeline small fixes. - [newton-physics/newton#2734](newton-physics/newton#2734) — `DelassusOperator` attribute refactor. Not used in IsaacLab source today (verified by grep), no adapt needed. - SolverMuJoCo fixes: planar meshes, contact-anchor computation, distance conversion. ## Required dep bumps None on the IsaacLab side. The `mjwarp 3.8.0.1 → 3.8.0.3` bump flows in transitively through `newton[sim]`, since [#5566](#5566) dropped IsaacLab's explicit `mujoco` / `mujoco-warp` pins. `warp-lang` stays at `1.13.0` (set by [#5523](#5523)). ## Pins updated | File | Change | |---|---| | `source/isaaclab_newton/setup.py` | `v1.2.0rc2` → `v1.2.0` | | `source/isaaclab_physx/setup.py` | `v1.2.0rc2` → `v1.2.0` | | `source/isaaclab_visualizers/setup.py` | 3× `v1.2.0rc2` → `v1.2.0` | | `tools/wheel_builder/res/python_packages.toml` | `v1.2.0rc2` → `v1.2.0` | ## Test plan - [x] Pre-commit clean. - [ ] CI smoke verifies clean install picks up `newton 1.2.0` and downstream `mjwarp 3.8.0.3`.
Summary
Bumps the Newton pin to
v1.2.0rc3, keeping the canonicalnewton[sim] @ git+...form across all five pin sites.Restores the bump that was briefly active on develop between isaac-sim/IsaacLab#5024 and isaac-sim/IsaacLab#5566 — isaac-sim/IsaacLab#5024 silently moved the pin to
newton==1.2.0rc3(PyPI form, dropping the[sim]extra), and isaac-sim/IsaacLab#5566 reverted it back tonewton[sim] @ git+...@v1.2.0rc2. This PR brings rc3 back, this time with the proper[sim]extra preserved everywhere.What's new in Newton v1.2.0rc3 vs v1.2.0rc2
Notable upstream fixes:
log_mesh(newton-physics/newton#2628) — rerun viewer.Required dep bumps
None on the IsaacLab side. Since isaac-sim/IsaacLab#5566 dropped IsaacLab's explicit
mujoco/mujoco-warppins, themjwarp 3.8.0.1 → 3.8.0.2bump in rc3 flows in transitively throughnewton[sim]with no IsaacLab-side change.warp-langstays at1.13.0(set by isaac-sim/IsaacLab#5523).Pins updated
source/isaaclab_newton/setup.pyv1.2.0rc2→v1.2.0rc3source/isaaclab_physx/setup.pyv1.2.0rc2→v1.2.0rc3source/isaaclab_visualizers/setup.pyv1.2.0rc2→v1.2.0rc3tools/wheel_builder/res/python_packages.tomlv1.2.0rc2→v1.2.0rc3Test plan
newton 1.2.0rc3and downstreammjwarp 3.8.0.2.Caveat
This is a version-string-only bump — no IsaacLab-side code adapts were needed. If any rc3 behavioral change (MPR/GJK convex-hull fix, SolverMuJoCo contact-anchor fix) surfaces a regression in scenes with off-center convex meshes or planar collision, those would need follow-up tracking.
Alternative: isaac-sim/IsaacLab#5616 bumps directly to v1.2.0rc4 — pick whichever target based on CI signal.