Adds support for underscore and hyphens in RL framework names#566
Merged
Conversation
Dhoeller19
approved these changes
Jun 25, 2024
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
…sim#566) According to PIP, both`rl_games` and `rl-games` are valid PIP packages and are resolved similarly. This MR adds support for the different name conventions of PIP packages in the `setup.py` for the `omni.isaac.lab_tasks` extension. Fixes isaac-sim#547 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have run all the tests with `./isaaclab.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…sim#566) According to PIP, both`rl_games` and `rl-games` are valid PIP packages and are resolved similarly. This MR adds support for the different name conventions of PIP packages in the `setup.py` for the `omni.isaac.lab_tasks` extension. Fixes isaac-sim#547 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have run all the tests with `./isaaclab.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
kellyguo11
pushed a commit
that referenced
this pull request
Aug 7, 2025
Running the job on the host
StephenWelch
pushed a commit
to StephenWelch/IsaacLab
that referenced
this pull request
Aug 17, 2025
Running the job on the host
george-nehma
pushed a commit
to george-nehma/DreamLander-IsaacLab
that referenced
this pull request
Oct 24, 2025
Running the job on the host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to PIP, both
rl_gamesandrl-gamesare valid PIP packages and are resolved similarly. This MR adds support for the different name conventions of PIP packages in thesetup.pyfor theomni.isaac.lab_tasksextension.Fixes #547
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --format./isaaclab.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there