tracing: remove uncommonly-used tuning configs#1591
tracing: remove uncommonly-used tuning configs#1591istio-testing merged 1 commit intoistio:masterfrom
Conversation
These configurations were added to be consistent with Stackdriver and provide extra performance tuning for OpenCensus. These are unlikely to be used in production. Tuning should probably be performed by Istio developers instead. We can remove the options for now. This was triggered by a conversation at the end of the previous CL merge: istio#1563 Change-Id: Iab148ff87dfe5b1772d3cdf2a009ec9cf4ea0f27 Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/596 Reviewed-by: Jungho Ahn <jungho.ahn@airbnb.com> Reviewed-by: Ying Zhu <ying.zhu@airbnb.com>
|
Hi @brianwolfe. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nrjpoddar @mandarjog PTAL. This is followup from the previous change: #1563 |
|
@nrjpoddar ping |
mandarjog
left a comment
There was a problem hiding this comment.
Lgtm
Makes sense, we can add them if needed.
|
@howardjohn can you ok-to-test this? I still don't have perms to do that. |
|
/ok-to-test |
These configurations were added to be consistent with Stackdriver and
provide extra performance tuning for OpenCensus. These are unlikely to
be used in production. Tuning should probably be performed by Istio
developers instead. We can remove the options for now.
This was triggered by a conversation at the end of the previous CL
merge. See: #1563
Change-Id: Iab148ff87dfe5b1772d3cdf2a009ec9cf4ea0f27
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/596
Reviewed-by: Jungho Ahn jungho.ahn@airbnb.com
Reviewed-by: Ying Zhu ying.zhu@airbnb.com