Skip to content

tracing: remove uncommonly-used tuning configs#1591

Merged
istio-testing merged 1 commit intoistio:masterfrom
airbnb:air-remove-debugging-configs
Aug 19, 2020
Merged

tracing: remove uncommonly-used tuning configs#1591
istio-testing merged 1 commit intoistio:masterfrom
airbnb:air-remove-debugging-configs

Conversation

@brianwolfe
Copy link
Copy Markdown
Member

These configurations were added to be consistent with Stackdriver and
provide extra performance tuning for OpenCensus. These are unlikely to
be used in production. Tuning should probably be performed by Istio
developers instead. We can remove the options for now.

This was triggered by a conversation at the end of the previous CL
merge. See: #1563

Change-Id: Iab148ff87dfe5b1772d3cdf2a009ec9cf4ea0f27
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/596
Reviewed-by: Jungho Ahn jungho.ahn@airbnb.com
Reviewed-by: Ying Zhu ying.zhu@airbnb.com

These configurations were added to be consistent with Stackdriver and
provide extra performance tuning for OpenCensus. These are unlikely to
be used in production. Tuning should probably be performed by Istio
developers instead. We can remove the options for now.

This was triggered by a conversation at the end of the previous CL
merge: istio#1563
Change-Id: Iab148ff87dfe5b1772d3cdf2a009ec9cf4ea0f27
Reviewed-on: https://gerrit.musta.ch/c/public/istio-api/+/596
Reviewed-by: Jungho Ahn <jungho.ahn@airbnb.com>
Reviewed-by: Ying Zhu <ying.zhu@airbnb.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 12, 2020
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Aug 12, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @brianwolfe. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brianwolfe
Copy link
Copy Markdown
Member Author

@nrjpoddar @mandarjog PTAL. This is followup from the previous change: #1563

@brianwolfe
Copy link
Copy Markdown
Member Author

@nrjpoddar ping

Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Makes sense, we can add them if needed.

@brianwolfe
Copy link
Copy Markdown
Member Author

@howardjohn can you ok-to-test this? I still don't have perms to do that.

@smawson
Copy link
Copy Markdown
Contributor

smawson commented Aug 19, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 19, 2020
@istio-testing istio-testing merged commit c78f387 into istio:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants