Skip to content

org/istio: add brianwolfe as developer#399

Merged
istio-testing merged 1 commit intoistio:masterfrom
brianwolfe:master
Aug 21, 2020
Merged

org/istio: add brianwolfe as developer#399
istio-testing merged 1 commit intoistio:masterfrom
brianwolfe:master

Conversation

@brianwolfe
Copy link
Copy Markdown
Member

@brianwolfe brianwolfe commented Aug 20, 2020

Trying to join as developer so I can /ok-to-test changes. I guess I had a race with @howardjohn's reorganization of the yaml files.

If you are joining the org, please fill out the template below:

List your company name, or indicate Individual if you're not affiliated with a company:
Airbnb

Provide a link to at least one PR that you have successfully pushed to one
of the Istio repos:
istio/api#1563
istio/api#1591

@brianwolfe brianwolfe requested a review from a team as a code owner August 20, 2020 17:43
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 20, 2020
@istio-testing
Copy link
Copy Markdown
Contributor

Hi @brianwolfe. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2020
@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Aug 20, 2020 via email

@brianwolfe
Copy link
Copy Markdown
Member Author

@linsun can you /ok-to-test this?

@linsun
Copy link
Copy Markdown
Member

linsun commented Aug 20, 2020

/ok-to-test

@brianwolfe brianwolfe changed the title org/istio: add brianwolfe as member org/istio: add brianwolfe as developer Aug 21, 2020
@brianwolfe
Copy link
Copy Markdown
Member Author

Rebased, looks like I had a race w/ @howardjohn's reorg of the yaml files. I think I added myself to the right spot.

Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing merged commit 6a1247a into istio:master Aug 21, 2020
daixiang0 pushed a commit to daixiang0/community that referenced this pull request Nov 14, 2025
Changed exceptions_due to 2023-11-13 10:00:01

Signed-off-by: georgestevens99 <georgiageorge99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants