Skip to content

Add mesh config to allow setting network policy fail open#672

Merged
rshriram merged 2 commits intoistio:release-1.0from
yangminzhu:failOpen
Oct 23, 2018
Merged

Add mesh config to allow setting network policy fail open#672
rshriram merged 2 commits intoistio:release-1.0from
yangminzhu:failOpen

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

@yangminzhu yangminzhu commented Oct 23, 2018

Cherrypick #670 to 1.0 branch.

istio/istio#9483, istio/istio#9485

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: diemtvu

If they are not already assigned, you can assign the PR to them by writing /assign @diemtvu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 23, 2018
@mandarjog
Copy link
Copy Markdown
Contributor

@yangminzhu please fix failed build. @douglas-reid does master and 1.0 use a different version of protoc / plugin?

@yangminzhu
Copy link
Copy Markdown
Contributor Author

@mandarjog I think it's just I didn't include the generated file before.

@rshriram rshriram merged commit 6bf9d66 into istio:release-1.0 Oct 23, 2018
@yangminzhu yangminzhu deleted the failOpen branch October 23, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants