Skip to content

Add mesh config to allow setting network policy fail open #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshriram merged 2 commits into from
Oct 23, 2018
+109 −74
Merged

Add mesh config to allow setting network policy fail open #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43bb63
Add mesh config to allow setting network policy fail open
yangminzhu Oct 23, 2018
463d45e
include generated proto
yangminzhu Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 59 additions & 46 deletions mesh/v1alpha1/config.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions mesh/v1alpha1/config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,11 @@ message MeshConfig {
// is false, i.e. mixer policy check is enabled by default.
bool disable_policy_checks = 3;

// Allow all traffic in cases when the mixer policy service cannot be reached.
// Default is false which means the traffic is denied when the client is unable
// to connect to Mixer.
bool policy_check_fail_open = 25;

// Port on which Envoy should listen for incoming connections from
// other services.
int32 proxy_listen_port = 4;
Expand Down
10 changes: 10 additions & 0 deletions mesh/v1alpha1/istio.mesh.v1alpha1.pb.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,16 @@ <h2 id="MeshConfig">MeshConfig</h2>
<p>Disable policy checks by the mixer service. Default
is false, i.e. mixer policy check is enabled by default.</p>

</td>
</tr>
<tr id="MeshConfig-policy_check_fail_open">
<td><code>policyCheckFailOpen</code></td>
<td><code>bool</code></td>
<td>
<p>Allow all traffic in cases when the mixer policy service cannot be reached.
Default is false which means the traffic is denied when the client is unable
to connect to Mixer.</p>

</td>
</tr>
<tr id="MeshConfig-proxy_listen_port">
Expand Down
Loading