Remove stale useless default_endpoint field in gateway.server#933
Remove stale useless default_endpoint field in gateway.server#933hzxuzhonghu wants to merge 5 commits intoistio:masterfrom
Conversation
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hzxuzhonghu If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This is a breaking change. Do we need a deprecation story here? |
|
How do we know this is stale? we definitely need release note this deprecation. |
| // `unix:///path/to/socket` or `unix://@foobar` (Linux abstract namespace). | ||
| string default_endpoint = 5; | ||
| reserved 5; | ||
| reserved "default_endpoint"; |
There was a problem hiding this comment.
why is this stale? this is implemented right? if not, my bad as I forgot about implementing this. This needs to be implemented.
There was a problem hiding this comment.
It is no implemented now.
|
I think you are looking at a wrong branch.. This field was added 5 months ago by me |
|
ok, then let me close it. |
* API tweaks * mega tweaks * delete useless files * all under tenant * transactions, permissions Mirrored from https://github.com/tetrateio/tetrate @ d6b7b4f8787e97107ec2250e174afd2bdef09fed
6 participants
No description provided.