Skip to content

Remove stale useless default_endpoint field in gateway.server #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzxuzhonghu wants to merge 5 commits into from
Closed

Remove stale useless default_endpoint field in gateway.server #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06d4dd0
remove stale useless fields default_endpoint in Gateway.Server
hzxuzhonghu May 30, 2019
8c901e3
reserve proto ID
hzxuzhonghu May 30, 2019
efd9989
reserve proto field
hzxuzhonghu May 30, 2019
e72140d
gen
hzxuzhonghu May 30, 2019
99696aa
make proto-commit
hzxuzhonghu May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 47 additions & 101 deletions networking/v1alpha3/gateway.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions networking/v1alpha3/gateway.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions networking/v1alpha3/gateway.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,8 @@ message Server {
// https, and the TLS modes to use.
TLSOptions tls = 3;

// The loopback IP endpoint or Unix domain socket to which traffic should
// be forwarded to by default. Format should be `127.0.0.1:PORT` or
// `unix:///path/to/socket` or `unix://@foobar` (Linux abstract namespace).
string default_endpoint = 5;
reserved 5;
reserved "default_endpoint";
Copy link
Copy Markdown
Member

@rshriram rshriram May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this stale? this is implemented right? if not, my bad as I forgot about implementing this. This needs to be implemented.

Copy link
Copy Markdown
Member Author

@hzxuzhonghu hzxuzhonghu May 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is no implemented now.

}

// Port describes the properties of a specific port of a service.
Expand Down
11 changes: 6 additions & 5 deletions proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3838,13 +3838,14 @@
"id": 3,
"name": "tls",
"type": "TLSOptions"
},
{
"id": 5,
"name": "default_endpoint",
"type": "string"
}
],
"reserved_ids": [
5
],
"reserved_names": [
"default_endpoint"
],
"messages": [
{
"name": "TLSOptions",
Expand Down
27 changes: 10 additions & 17 deletions python/istio_api/networking/v1alpha3/gateway_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.