Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ imagePullPolicy| [ImagePullPolicy](https://kubernetes.io/docs/concepts/container
priorityClassName | [priority class name](https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/#priorityclass)
nodeSelector| [node selector](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector)
affinity | [affinity and anti-affinity](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity)
serviceAnnotations | [service annotations](https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/)

These K8s setting are available for each component under the `k8s` field, for example:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,5 @@ spec:
requests:
cpu: 888m
memory: 999Mi
serviceAnnotations:
cloud.google.com/load-balancer-type: "internal"
Original file line number Diff line number Diff line change
Expand Up @@ -7338,12 +7338,14 @@ spec:
apiVersion: v1
kind: Service
metadata:
name: istio-telemetry
namespace: istio-telemetry
annotations:
cloud.google.com/load-balancer-type: internal
labels:
app: mixer
istio: mixer
release: istio
name: istio-telemetry
namespace: istio-telemetry
spec:
ports:
- name: grpc-mixer
Expand All @@ -7357,6 +7359,7 @@ spec:
selector:
istio: mixer
istio-mixer-type: telemetry

---


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ spec:
requests:
cpu: 100m
memory: 128Mi
serviceAnnotations: {}
strategy:
rollingUpdate:
maxSurge: 100%
Expand Down Expand Up @@ -103,6 +104,7 @@ spec:
requests:
cpu: 100m
memory: 128Mi
serviceAnnotations: {}
strategy:
rollingUpdate:
maxSurge: 100%
Expand Down
3 changes: 2 additions & 1 deletion data/translateConfig/reverseTranslateConfig-1.5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ kubernetesPatternMapping:
"{{.ValueComponentName}}.replicaCount": "{{.FeatureName}}.Components.{{.ComponentName}}.K8s.ReplicaCount"
"{{.ValueComponentName}}.resources": "{{.FeatureName}}.Components.{{.ComponentName}}.K8s.Resources"
"{{.ValueComponentName}}.rollingMaxSurge": "{{.FeatureName}}.Components.{{.ComponentName}}.K8s.Strategy"
"{{.ValueComponentName}}.rollingMaxUnavailable": "{{.FeatureName}}.Components.{{.ComponentName}}.K8s.Strategy"
"{{.ValueComponentName}}.rollingMaxUnavailable": "{{.FeatureName}}.Components.{{.ComponentName}}.K8s.Strategy"
"{{.ValueComponentName}}.serviceAnnotations": "{{.FeatureName}}.Components.{{.ComponentName}}.K8s.ServiceAnnotations"
2 changes: 2 additions & 0 deletions data/translateConfig/translateConfig-1.5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ kubernetesMapping:
outPath: "[{{.ResourceType}}:{{.ResourceName}}].spec.strategy"
"{{.FeatureName}}.Components.{{.ComponentName}}.K8S.Tolerations":
outPath: "[{{.ResourceType}}:{{.ResourceName}}].spec.template.spec.tolerations"
"{{.FeatureName}}.Components.{{.ComponentName}}.K8S.ServiceAnnotations":
outPath: "[Service:{{.ResourceName}}].metadata.annotations"
toFeature:
Base: Base
Pilot: TrafficManagement
Expand Down
341 changes: 177 additions & 164 deletions pkg/apis/istio/v1alpha2/istiocontrolplane_types.pb.go

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions pkg/apis/istio/v1alpha2/istiocontrolplane_types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,9 @@ message KubernetesResourcesSpec {
// k8s toleration
// https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
repeated k8s.io.api.core.v1.Toleration tolerations = 14;
// k8s service annotations.
// https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
map<string, string> service_annotations = 15;

// Overlays for k8s resources in rendered manifests.
repeated k8sObjectOverlay overlays = 100;
Expand Down
12 changes: 12 additions & 0 deletions pkg/apis/istio/v1alpha2/v1alpha2.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion pkg/vfs/assets.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.