This repository was archived by the owner on Oct 7, 2020. It is now read-only.
add serviceAnnotation to KubernetesResourcesSpec.#736
Merged
istio-testing merged 1 commit intoistio:masterfrom Jan 8, 2020
Merged
add serviceAnnotation to KubernetesResourcesSpec.#736istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
elfinhe
approved these changes
Jan 8, 2020
Contributor
|
@morvencao sorry about this but you may need to redo the PR due to #713 as I wasn't able to merge this cleanly. Please wait a couple of days for operator to merge to istio/istio and check if your code looks ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve: istio/istio#19959