This repository was archived by the owner on Oct 7, 2020. It is now read-only.
add serviceAnnotation to KubernetesResourcesSpec.#740
Merged
istio-testing merged 1 commit intoistio:masterfrom Jan 12, 2020
Merged
add serviceAnnotation to KubernetesResourcesSpec.#740istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
Member
|
lgtm |
elfinhe
reviewed
Jan 9, 2020
Member
elfinhe
left a comment
elfinhe
left a comment
There was a problem hiding this comment.
maybe we need to wait until the tests on master gets fixed?
Member
Author
|
@elfinhe These failed tests depend on istio/api#1230 |
istio-testing
added
size/S
morvencao
force-pushed
the
br_add_service_annotation_support
branch
2 times, most recently
from
3853168 to
85daebc
Compare
Member
Author
|
/test test_operator |
elfinhe
approved these changes
Jan 11, 2020
morvencao
force-pushed
the
br_add_service_annotation_support
branch
from
85daebc to
66ceef1
Compare
istio-testing
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resubmit: #736 due to #713
depends on: istio/api#1230