Migrate code to use IstioOperator API in istio/api by ostromart · Pull Request #713 · istio/operator

ostromart · 2019-12-21T01:03:03Z

See the corresponding API change:
istio/api#1223

…te-api

howardjohn · 2019-12-21T01:50:46Z

 selected profile values and passed to a renderer in the Helm library to create manifests. Further customization on the
 created manifests can be done through overlays. 
-1. [CLI](#cli) code. CLI code shares the `IstioControlPlaneSpec` API with
+1. [CLI](#cli) code. CLI code shares the `IstioOperatorSpec` API with


Dumb question now, but isn't this used for istioctl as well?

howardjohn · 2019-12-22T15:36:02Z

@@ -1,67 +1,60 @@
 apiVersion: install.istio.io/v1alpha2


if we are changing the API don't we need to increment the api version?

Actually this is a brand new API - just updated PR to reflect that.

richardwxn

overall looks good to me, will take another detailed look again next week

richardwxn · 2019-12-22T21:15:15Z

+- The new [platform level installation API](https://github.com/istio/api/mesh/v1alpha1/operator.proto), for managing
 K8s settings like resources, auto scaling, pod disruption budgets and others defined in the
-[KubernetesResourceSpec](https://github.com/istio/operator/blob/905dd84e868a0b88c08d95b7ccf14d085d9a6f6b/pkg/apis/istio/v1alpha2/istiocontrolplane_types.proto#L411)
+[KubernetesResourceSpec](https://github.com/istio/api/blob/7791470ecc4c5e123589ff2b781f47b1bcae6ddd/mesh/v1alpha1/component.proto#L103)


nit: can you point the link to master instead

…te-api

richardwxn

@ostromart is it ready for review again? Hope this PR can be merged soon first to unblock other PRs.

ostromart · 2020-01-06T22:41:59Z

/retest

…te-api

morvencao · 2020-01-07T07:55:34Z

@@ -1,18 +1,4 @@
 apiVersion: install.istio.io/v1alpha2


Shouldn't the apiVersion be operator.istio.io/v1alpha1?

morvencao · 2020-01-07T07:56:24Z

@@ -1,18 +1,38 @@
 apiVersion: install.istio.io/v1alpha2


also here, should be operator.istio.io/v1alpha1?

…te-api

elfinhe · 2020-01-08T18:52:50Z

we should block the master from merging other PRs before we merge this one.

istio-testing · 2020-01-08T19:37:53Z

@ostromart: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
e2e_operator	`f061a7a`	link	`/test e2e_operator`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Migrate code to use IstioOperator API in istio/api

fc632a5

ostromart requested a review from a team as a code owner December 21, 2019 01:03

googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 21, 2019

istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 21, 2019

Merge branch 'master' of https://github.com/istio/operator into migra…

2802506

…te-api

istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 21, 2019

howardjohn reviewed Dec 21, 2019

View reviewed changes

howardjohn reviewed Dec 22, 2019

View reviewed changes

richardwxn reviewed Dec 22, 2019

View reviewed changes

ostromart added 6 commits December 26, 2019 16:29

Fix manifest generation

c5e9ec2

Prometheus test case

edae397

Refactor addons and gateways

34b6636

Add gateway indexing

edbe070

Fix remaining tests

5d96644

Fix controller test

4a43b4a

istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 30, 2019

Merge branch 'master' of https://github.com/istio/operator into migra…

e7b6892

…te-api

istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 30, 2019

Update profiles with new CR headers

e34e490

This was referenced Jan 3, 2020

add service to k8s spec #711

Open

Check enablement from values part as well #727

Open

ostromart added 3 commits January 3, 2020 09:38

Update readme

644e357

Fix dependency processing

9338e04

Add passthrough for values to gateways

9929214

istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 3, 2020

ostromart added 3 commits January 3, 2020 14:58

Add addon name field

8480988

More test fixes

05b2627

Add default gateway override test case

0ff0f91

richardwxn reviewed Jan 5, 2020

View reviewed changes

ostromart added 2 commits January 6, 2020 13:03

Fix remaining mandiff profiles

ec4b563

Update goldens

80d2111

elfinhe approved these changes Jan 6, 2020

View reviewed changes

Fix addon status

1fce1aa

ostromart added 5 commits January 6, 2020 15:49

Remove lingering references to IstioControlPlane

c37865d

Make gen

86e6fbc

Update fields to refer to istiooperator

a7093e5

Update to v1alpha1

393f781

Merge branch 'master' of https://github.com/istio/operator into migra…

ee71ef1

…te-api

morvencao reviewed Jan 7, 2020

View reviewed changes

ostromart added 7 commits January 7, 2020 09:16

Change CRD meta to plural

88880a1

Merge branch 'master' of https://github.com/istio/operator into migra…

b707f51

…te-api

Remove lingering v1alpha2, icp references

62d6d36

Move CR back to istio-system

ffd072a

Rename local vars from icp to iop

43a3cae

Change deployment filenames back to v1alpha2 since tests expect it

b8f1bfa

Merge branch 'master' of https://github.com/istio/operator into migra…

736eaf8

…te-api

Make gen

3dcf011

ostromart mentioned this pull request Jan 8, 2020

add serviceAnnotation to KubernetesResourcesSpec. #736

Merged

attempt to fix test

f061a7a

howardjohn merged commit 1718c69 into istio:master Jan 8, 2020

ostromart mentioned this pull request Feb 7, 2020

Installation option for multiple ingress gateways, actually with ability to create additional internal load balancer in AWS istio/istio#19263

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate code to use IstioOperator API in istio/api#713

Migrate code to use IstioOperator API in istio/api#713
howardjohn merged 40 commits intoistio:masterfrom
ostromart:migrate-api

ostromart commented Dec 21, 2019 •

edited

Loading

Uh oh!

howardjohn Dec 21, 2019

Uh oh!

howardjohn Dec 22, 2019

Uh oh!

ostromart Jan 2, 2020

Uh oh!

richardwxn left a comment

Uh oh!

richardwxn Dec 22, 2019

Uh oh!

richardwxn left a comment

Uh oh!

ostromart commented Jan 6, 2020

Uh oh!

morvencao Jan 7, 2020

Uh oh!

morvencao Jan 7, 2020

Uh oh!

elfinhe commented Jan 8, 2020

Uh oh!

istio-testing commented Jan 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

ostromart commented Dec 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

howardjohn Dec 21, 2019

Choose a reason for hiding this comment

Uh oh!

howardjohn Dec 22, 2019

Choose a reason for hiding this comment

Uh oh!

ostromart Jan 2, 2020

Choose a reason for hiding this comment

Uh oh!

richardwxn left a comment

Choose a reason for hiding this comment

Uh oh!

richardwxn Dec 22, 2019

Choose a reason for hiding this comment

Uh oh!

richardwxn left a comment

Choose a reason for hiding this comment

Uh oh!

ostromart commented Jan 6, 2020

Uh oh!

morvencao Jan 7, 2020

Choose a reason for hiding this comment

Uh oh!

morvencao Jan 7, 2020

Choose a reason for hiding this comment

Uh oh!

elfinhe commented Jan 8, 2020

Uh oh!

istio-testing commented Jan 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ostromart commented Dec 21, 2019 •

edited

Loading