Create child spans for mixer check calls

[bianpengyuan]

No description provided.

[istio-testing]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun

Assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bianpengyuan]

Now tracing looks like this:

cc @douglas-reid @kyessenov

[mandarjog]

This seems odd. The labels say “report” while calling istio-policy, should say check?

[bianpengyuan]

@mandarjog Yes, that is a separated problem. I am going to fix it as well, and I think the problem is in policy's sidecar config?

[kyessenov]

@mandarjog Yes, that's a bug. Check/Report are swapped: https://github.com/istio/istio/blob/master/pilot/docker/envoy_telemetry.yaml.tmpl

[kyessenov]

PR out istio/istio#5283

[kyessenov]

Why is there two Check calls on the first hop?

[bianpengyuan]

@kyessenov One from Ingress and one from productpage sidecar.

[douglas-reid]

Reminder: These PRs should be against the 0.8 release branch, instead of master. Please re-open against the correct branch (as master is now locked).

[douglas-reid]

Should ingress itself also not have a span?

[kyessenov]

Yes, ingress tracing has issues, too, I think. My expectation is that the check should be on a span that reaches ingress service, not the outbound call from ingress. That's not how it looks on the chart. Additionally, we should probably try a gateway as well.

…

On Sat, Apr 28, 2018, 2:12 PM Douglas Reid ***@***.***> wrote: Should ingress itself also not have a span? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1593 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJGIxgTXsLitR1lWJD7nTCJjS_j3MLlbks5ttNs-gaJpZM4TrRs0> .

[bianpengyuan]

Close this one with another one open in 0.8 branch: #1610