Create a child span for mixer check call#1610
Conversation
googlebot
added
the
cla: yes
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
rshriram
left a comment
rshriram
left a comment
There was a problem hiding this comment.
Envoy has an API for filters to create a child span from the current Envoy Span. Please see if that can be used.
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Plese see this: |
|
/lgtm cancel |
|
@kyessenov @douglas-reid @mandarjog Just FYI the new trace will look like this: |
|
The trace looks awesome. Exactly what I would want to see from it (latency
between hops).
…On Tue, May 1, 2018 at 12:04 PM Pengyuan Bian ***@***.***> wrote:
@kyessenov <https://github.com/kyessenov> @douglas-reid
<https://github.com/douglas-reid> @mandarjog
<https://github.com/mandarjog> Just FYI the new trace will look like this:
[image: screenshot from 2018-05-01 11-57-21]
<https://user-images.githubusercontent.com/34738376/39488392-fba141b8-4d36-11e8-8a62-0efbe9a45c99.png>
and an individual check span:
[image: screenshot from 2018-05-01 11-57-51]
<https://user-images.githubusercontent.com/34738376/39488411-0a214fa8-4d37-11e8-9d99-7c44643ff94a.png>
The report/check name problem will be resolved by istio/istio#5335
<istio/istio#5335>. If we want to separate
ingress out of the first hop, start_child_span
<https://www.envoyproxy.io/docs/envoy/latest/api-v2/config/filter/http/router/v2/router.proto>
needs to be true in ingress router config.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1610 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJGIxiZhyVYZtca7T-S4DvDF8CZpU8Eyks5tuLGvgaJpZM4TrmSH>
.
|
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Is there an issue tracking that this is needed for 0.8? |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test proxy-presubmit-asan |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@geeknoid the issue is istio/old_issues_repo#306 (and other instances, this was debugged for awhile). I think it's pretty important, since without the fix, we get incorrect traces (a regression from 0.7). |
|
Automatic merge from submit-queue. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Once again, please DO NOT change the setting of a robot. A robot need right access to do its job.
|
|
It might have been changed in the attempt to stop the merge from merging to master, which is now locked due to code orange. Let's just disable the merge bot also for istio/proxy for now (already done that for istio/istio). |
|
Please contact @istio/test-infra-hackers for the help and behavior change of istio robots. |
|
Automatic merge from submit-queue. |
|
Disabled merge robot |
|
@bianpengyuan @kyessenov what are the chances we can get the updated proxy image with these changes in now as well? |
12 participants
No description provided.