Envoy rebase to 5843954375fe#1762
Conversation
Envoy commit 5843954 adds a sendLocalReply() callback that formats gRPC responses when the request was gRPC, HTTP response otherwise. test changes are due to Envoy commit 7379c35 ("test: remove response_ as member variable. (istio#3314)"). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Without explicitly calling 'waitForEndStream()' the response decoder could be destructed while a pointer to it is still held in stream callbacks, which then leads to use-after-free when those callbacks are called. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jrajahalme Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
|
Hi @jrajahalme. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
#1759 will cover this. |
|
@qiwzhang However, a cherry-pick would be appreciated. |
|
@jrajahalme Thanks. I will cherry-pick the change. |
4 participants
Envoy commit 5843954 adds a
sendLocalReply() callback that formats gRPC responses when the request
was gRPC, HTTP response otherwise.
test changes are due to Envoy commit
7379c35 ("test: remove response_ as
member variable. (#3314)").
Signed-off-by: Jarno Rajahalme jarno@covalent.io