http: Bump Envoy dependency to 5843954375fe548776d3d5c36ff8bb79cd61f2a0#1758
http: Bump Envoy dependency to 5843954375fe548776d3d5c36ff8bb79cd61f2a0#1758jrajahalme wants to merge 1 commit into
Conversation
Envoy commit 5843954 adds a sendLocalReply() callback that formats gRPC responses when the request was gRPC, HTTP response otherwise. test changes are due to Envoy commit 7379c35 ("test: remove response_ as member variable. (istio#3314)"). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jrajahalme Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Did the CLA, not sure if I need to do something for this PR to update the CLA status. |
|
CLAs look good, thanks! |
|
/ok-to-test |
|
Would you mind bumping all the way upto latest commit in Envoy ? I would like to pull in SNI forwarding as well. |
|
@jrajahalme: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Duplicates #1757 |
|
I am going to create a separate PR to make these change into release-0.8 branch. |
|
All changes in the release-0.8 branch will be merged into master later. |
|
@qiwzhang Sorry did not realize master is closed for the release. |
|
@rshriram @qiwzhang Opened a new PR (#1762) against release-0.8 branch that adds missing test infra calls to fix the asan/tsan CI failures seen on this and derived PRs. IMO it would be proper to merge this new PR before applying further Envoy-related changes to either release-0.8 or master branches, please have a look: |
Envoy commit 5843954 adds a
sendLocalReply() callback that formats gRPC responses when the request
was gRPC, HTTP response otherwise.
test changes are due to Envoy commit
7379c35 ("test: remove response_ as
member variable. (#3314)").
Signed-off-by: Jarno Rajahalme jarno@covalent.io