Skip to content

http: Bump Envoy dependency to 5843954375fe548776d3d5c36ff8bb79cd61f2a0#1758

Closed
jrajahalme wants to merge 1 commit into
istio:masterfrom
jrajahalme:envoy-rebase
Closed

http: Bump Envoy dependency to 5843954375fe548776d3d5c36ff8bb79cd61f2a0#1758
jrajahalme wants to merge 1 commit into
istio:masterfrom
jrajahalme:envoy-rebase

Conversation

@jrajahalme
Copy link
Copy Markdown

Envoy commit 5843954 adds a
sendLocalReply() callback that formats gRPC responses when the request
was gRPC, HTTP response otherwise.

test changes are due to Envoy commit
7379c35 ("test: remove response_ as
member variable. (#3314)").

Signed-off-by: Jarno Rajahalme jarno@covalent.io

Envoy commit 5843954 adds a
sendLocalReply() callback that formats gRPC responses when the request
was gRPC, HTTP response otherwise.

test changes are due to Envoy commit
7379c35 ("test: remove response_ as
member variable. (istio#3314)").

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrajahalme
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmycyj

Assign the PR to them by writing /assign @jimmycyj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 19, 2018
@istio-testing istio-testing requested review from JimmyCYJ and linsun May 19, 2018 00:49
@jrajahalme
Copy link
Copy Markdown
Author

Did the CLA, not sure if I need to do something for this PR to update the CLA status.

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 19, 2018
@rshriram
Copy link
Copy Markdown
Member

/ok-to-test

@rshriram
Copy link
Copy Markdown
Member

Would you mind bumping all the way upto latest commit in Envoy ? I would like to pull in SNI forwarding as well.

@istio-testing
Copy link
Copy Markdown
Collaborator

@jrajahalme: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit.sh 0606616 link /test proxy-presubmit
prow/proxy-presubmit-tsan.sh 0606616 link /test proxy-presubmit-tsan
prow/proxy-presubmit-asan.sh 0606616 link /test proxy-presubmit-asan
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qiwzhang qiwzhang closed this May 21, 2018
@rlenglet
Copy link
Copy Markdown
Contributor

Duplicates #1757

@qiwzhang
Copy link
Copy Markdown
Contributor

I am going to create a separate PR to make these change into release-0.8 branch.

@qiwzhang
Copy link
Copy Markdown
Contributor

All changes in the release-0.8 branch will be merged into master later.

@jrajahalme
Copy link
Copy Markdown
Author

@qiwzhang Sorry did not realize master is closed for the release.

@jrajahalme
Copy link
Copy Markdown
Author

@rshriram @qiwzhang Opened a new PR (#1762) against release-0.8 branch that adds missing test infra calls to fix the asan/tsan CI failures seen on this and derived PRs. IMO it would be proper to merge this new PR before applying further Envoy-related changes to either release-0.8 or master branches, please have a look:

#1762

@qiwzhang
Copy link
Copy Markdown
Contributor

@jrajahalme @rshriram

Are you saying we only need Envoy sha "5843954375fe548776d3d5c36ff8bb79cd61f2a0"?
My PR #1762 has updated envoy sha to today latest, (bb6762a). but it is blocked by an integration test failure. I will try 5843954, if it passed, I will move my pr to 5843954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants