update envoy sha for sni#1757
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ijsnellf Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ijsnellf: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Looks like it isn't as easy as updating the SHA, unfortunately. @lizan, does this look like something I can handle easily, or will it require code changes? |
|
It looks like it is due to the change to method signature of |
|
I can give it a try, but it would probably make more sense for someone with familiarity with the code base to make the changes. |
|
#1758 did those changes but was closed before merging. |
|
Replace it with #1759 |
What this PR does / why we need it:
Updates Envoy SHA so that SNI is available. SNI support was merged here: envoyproxy/envoy#3217
I am not sure about the update process for istio/proxy, so please double check this PR.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: