Skip to content

update envoy sha for sni#1757

Closed
ijsnellf wants to merge 1 commit into
istio:release-0.8from
ijsnellf:update_proxy_for_sni
Closed

update envoy sha for sni#1757
ijsnellf wants to merge 1 commit into
istio:release-0.8from
ijsnellf:update_proxy_for_sni

Conversation

@ijsnellf
Copy link
Copy Markdown

What this PR does / why we need it:
Updates Envoy SHA so that SNI is available. SNI support was merged here: envoyproxy/envoy#3217

I am not sure about the update process for istio/proxy, so please double check this PR.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@istio-testing istio-testing requested review from JimmyCYJ and lizan May 18, 2018 18:20
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 18, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ijsnellf
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmycyj

Assign the PR to them by writing /assign @jimmycyj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit-tsan.sh c26ad9d link /test proxy-presubmit-tsan
prow/proxy-presubmit-asan.sh c26ad9d link /test proxy-presubmit-asan
prow/proxy-presubmit.sh c26ad9d link /test proxy-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf
Copy link
Copy Markdown
Author

Looks like it isn't as easy as updating the SHA, unfortunately. @lizan, does this look like something I can handle easily, or will it require code changes?

@lizan
Copy link
Copy Markdown
Contributor

lizan commented May 18, 2018

It looks like it is due to the change to method signature of sendLocalReply, so the code change should be easy. Though if you're not familiar with the code base, someone from proxy can handle it.

@rshriram rshriram requested a review from qiwzhang May 18, 2018 21:53
@ijsnellf
Copy link
Copy Markdown
Author

I can give it a try, but it would probably make more sense for someone with familiarity with the code base to make the changes.

@rlenglet
Copy link
Copy Markdown
Contributor

#1758 did those changes but was closed before merging.

@qiwzhang
Copy link
Copy Markdown
Contributor

Replace it with #1759

@qiwzhang qiwzhang closed this May 21, 2018
@ijsnellf ijsnellf deleted the update_proxy_for_sni branch May 21, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants