Skip to content

Update Envoy so that SNI is available#1756

Closed
ijsnellf wants to merge 4 commits into
istio:release-0.8from
ijsnellf:update_sha_sni
Closed

Update Envoy so that SNI is available#1756
ijsnellf wants to merge 4 commits into
istio:release-0.8from
ijsnellf:update_sha_sni

Conversation

@ijsnellf
Copy link
Copy Markdown

What this PR does / why we need it:
Updates Envoy SHA so that SNI is available. SNI support was merged here: envoyproxy/envoy#3217

I am not sure about the update process for istio/proxy, so please double check this PR.

Which issue this PR fixes

Special notes for your reviewer:

Release note:

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ijsnellf
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas

Assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 18, 2018
@istio-testing istio-testing requested review from lizan and qiwzhang May 18, 2018 16:00
@istio-testing
Copy link
Copy Markdown
Collaborator

@ijsnellf: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit-asan.sh acef8a5 link /test proxy-presubmit-asan
prow/proxy-presubmit-tsan.sh acef8a5 link /test proxy-presubmit-tsan
prow/proxy-presubmit.sh acef8a5 link /test proxy-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram rshriram changed the base branch from master to release-0.8 May 18, 2018 17:56
@rshriram rshriram changed the base branch from release-0.8 to master May 18, 2018 17:57
@lizan
Copy link
Copy Markdown
Contributor

lizan commented May 18, 2018

@rshriram if istio/istio#5715 goes to 0.8, then shouldn't this also go to 0.8?

@ijsnellf ijsnellf changed the base branch from master to release-0.8 May 18, 2018 18:17
@ijsnellf
Copy link
Copy Markdown
Author

You are right. I'm closing this PR in favor of this one: #1757

@ijsnellf ijsnellf closed this May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants