Skip to content

Merging release-0.8 to master#1750

Merged
hklai merged 13 commits into
istio:masterfrom
hklai:release-0.8
May 15, 2018
Merged

Merging release-0.8 to master#1750
hklai merged 13 commits into
istio:masterfrom
hklai:release-0.8

Conversation

@hklai
Copy link
Copy Markdown
Contributor

@hklai hklai commented May 14, 2018

We are close to cutting a RC in release-0.8 for testing, so we are merging the commits in release-0.8 back to the master, to prepare for unlocking master.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 14, 2018
@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label May 14, 2018
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label May 14, 2018
@hklai hklai added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels May 14, 2018
@googlebot
Copy link
Copy Markdown
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@rkpagadala rkpagadala requested review from qiwzhang and removed request for qiwzhang May 14, 2018 23:02
@qiwzhang
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit 709a366 into istio:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants