Mac current and legacy#1768
Conversation
|
Thanks! :) Tagging for 3.8.0 as it avoids a regression (#1738). |
|
The build seems to be broken on macOS (new) |
|
Hmm, ok. Must have overlooked something when omitting a build suffix. Will fix soon. |
There was a problem hiding this comment.
Looks good to me. :)
The only thing I'm wondering is if and how we could or should make the difference clearer (thinking of the Github release entry). Would legacy be clear enough? Adding all targeted, legacy code names to the file name would probably make it too long as well. So it might be best to keep legacy as this PR does.
Current version uses Qt 5.15.2 to support macOS 10.13 (High Sierra) to 11 (Big Sur) Legacy version uses Qt 5.9.9 to support macOS 10.10 (Yosemite) to 10.12 (Sierra)
softins
force-pushed
the
mac-current-and-legacy
branch
from
48e7393 to
2daeaf4
Compare
I went through the same thought process, and came to the same conclusion. I think we just need to make it clear in the release notes, based on my first comment above. |
| echo "" | ||
| echo "" | ||
| artifact_deploy_filename=jamulus_${jamulus_buildversionstring}_mac.dmg | ||
| artifact_deploy_filename=jamulus_${jamulus_buildversionstring}_mac${BUILD_SUFFIX}.dmg |
There was a problem hiding this comment.
This also needs to be specified on the website (new variable and button on the macOS page).
There was a problem hiding this comment.
|
@JohannesBrx see this PR. |
3 participants
This PR updates the autobuild of artifacts to create two builds for Mac, using Qt 5.15.2 for the main Mac build and Qt 5.9.9 for a legacy Mac build.
Users of macOS 10.13 (High Sierra) onwards should use the main Mac build, and users of macOS 10.10 (Yosemite), 10.11 (El Capitan) and 10.12 (Sierra) should use the legacy Mac build.
This fixes both #1628 and #1738