Skip to content

Add legacy build variable#490

Merged
ann0see merged 1 commit intotranslate3_8_0from
addLegacyBuild
May 28, 2021
Merged

Add legacy build variable#490
ann0see merged 1 commit intotranslate3_8_0from
addLegacyBuild

Conversation

@ann0see
Copy link
Copy Markdown
Member

@ann0see ann0see commented May 28, 2021

Related to jamulussoftware/jamulus#1768

Does this need translation?

  • Yes
  • No

Changes

Add a variable to allow direct download of legacy builds. While strictly this doesn't require translations; we might need to add other buttons somewhere (for the legacy build).

@ann0see ann0see merged commit f0783c6 into translate3_8_0 May 28, 2021
@ann0see ann0see deleted the addLegacyBuild branch May 28, 2021 10:48
@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented May 28, 2021

Merged since the main PR by softins was merged too.

@ann0see ann0see added this to the Release 3.8.0 milestone May 28, 2021
@jujudusud
Copy link
Copy Markdown
Member

It is called 'mac-lagacy' ?

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented May 28, 2021

No. jamulus_version_mac_legacy.dmg

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented May 28, 2021

For me it's jamulus_3.8.0rc1dev-8789c32_mac_legacy.dmg

@jujudusud
Copy link
Copy Markdown
Member

Capture d’écran du 2021-05-28 16-21-45

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented May 28, 2021

Ah. You mean the variable. Yes, that's mac-legacy ;-)

@jujudusud
Copy link
Copy Markdown
Member

Should be, but for now it is not ... and it is merged ... :-(

Comment thread _config.yml
deb-headless: "jamulus_headless_3.7.0_ubuntu_amd64.deb"
windows: "jamulus_3.7.0_win.exe"
mac: "jamulus_3.7.0_mac.dmg"
mac-lagacy: "jamulus_3_7_0_mac_legacy.dmg"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:
mac-legacy

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoffie
Copy link
Copy Markdown
Member

hoffie commented May 28, 2021

Ah. You mean the variable. Yes, that's mac-legacy ;-)

- in yaml keys looks a bit strange, but other targets (deb-headless) use it as well, so it should work.

@ignotus666
Copy link
Copy Markdown
Member

I think he means the spelling: lagacy vs legacy

@hoffie
Copy link
Copy Markdown
Member

hoffie commented May 28, 2021

I think he means the spelling: lagacy vs legacy

Aaah! I agree. Thanks @jujudusud (for pointing it out) and @ignotus666 (for clarification). Yes, this should be adapted. Can someone provide a fix?

@jujudusud
Copy link
Copy Markdown
Member

Will do

@ann0see
Copy link
Copy Markdown
Member Author

ann0see commented May 28, 2021

Uh… now I understand ;-(. Happy if you fix it @jujudusud

hoffie pushed a commit that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants