Skip to content

Add transparency to vibraphone icon#2158

Merged
softins merged 1 commit intojamulussoftware:masterfrom
softins:vibraphone-icon
Dec 17, 2021
Merged

Add transparency to vibraphone icon#2158
softins merged 1 commit intojamulussoftware:masterfrom
softins:vibraphone-icon

Conversation

@softins
Copy link
Copy Markdown
Member

@softins softins commented Dec 8, 2021

Short description of changes

Updates the vibraphone icon (introduced in #2080) to include a transparent background.

Context: Fixes an issue?

With the original vibraphone icon, the channel label looks like this:
image

With the replacement icon, it looks like this:
image

All the other instrument icons already have a transparent background.

Does this change need documentation? What needs to be documented and how?

No documentation changes.

Status of this Pull Request

Tested and working.

What is missing until this pull request can be merged?

Ready to merge.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@softins softins requested review from gilgongo and pljones December 8, 2021 16:16
@pljones
Copy link
Copy Markdown
Collaborator

pljones commented Dec 8, 2021

Can you show it in Compact, too, compared with some of the other icons, preferably (e.g. guitar/vocals).

@softins
Copy link
Copy Markdown
Member Author

softins commented Dec 14, 2021

Can you show it in Compact, too, compared with some of the other icons, preferably (e.g. guitar/vocals).

Sure, I haven't changed the icon size (except reduced the height from 28px to 27px to match all the others), just its transparency.

Here is the old icon in Fancy mode:
image
And Normal mode:
image
And Compact mode:
image

Now the new icon in Fancy mode:
image
And Normal mode:
image
And Compact mode:
image

Copy link
Copy Markdown
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks better. So now icon reviews need:

  • ideally all platforms
  • all fader sizes
  • all background shades (to avoid things like a pale green icon "vanishing"...)

@softins
Copy link
Copy Markdown
Member Author

softins commented Dec 17, 2021

I don't think there's anything contentious here, so I'll just merge as admin with one approval.

@softins softins merged commit 48e321d into jamulussoftware:master Dec 17, 2021
@softins softins deleted the vibraphone-icon branch January 11, 2022 12:17
@gilgongo gilgongo added this to the 3.8.2 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants