Add transparency to vibraphone icon#2158
Merged
softins merged 1 commit intojamulussoftware:masterfrom Dec 17, 2021
Merged
Conversation
Collaborator
|
Can you show it in Compact, too, compared with some of the other icons, preferably (e.g. guitar/vocals). |
Member
Author
pljones
approved these changes
Dec 14, 2021
Member
Author
|
I don't think there's anything contentious here, so I'll just merge as admin with one approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Short description of changes
Updates the vibraphone icon (introduced in #2080) to include a transparent background.
Context: Fixes an issue?
With the original vibraphone icon, the channel label looks like this:

With the replacement icon, it looks like this:

All the other instrument icons already have a transparent background.
Does this change need documentation? What needs to be documented and how?
No documentation changes.
Status of this Pull Request
Tested and working.
What is missing until this pull request can be merged?
Ready to merge.
Checklist