Skip to content

Added entries for all the changes since 3.8.1#2249

Merged
softins merged 1 commit intojamulussoftware:masterfrom
softins:changelog-382
Jan 21, 2022
Merged

Added entries for all the changes since 3.8.1#2249
softins merged 1 commit intojamulussoftware:masterfrom
softins:changelog-382

Conversation

@softins
Copy link
Copy Markdown
Member

@softins softins commented Jan 18, 2022

This is the first draft of the ChangeLog additions since 3.8.1, for review and comment.

It was produced while examining the output of git log --graph master...r3_8_1

@softins softins added this to the 3.8.2 milestone Jan 18, 2022
@softins softins mentioned this pull request Jan 18, 2022
56 tasks
Comment thread ChangeLog Outdated
@softins
Copy link
Copy Markdown
Member Author

softins commented Jan 18, 2022

I have verified that all the users mentioned in this section of the ChangeLog are already in the contributors list in src/util.cpp.

@ghost
Copy link
Copy Markdown

ghost commented Jan 18, 2022

@vibraphon provided a picture of his home built vibraphone for Jamulus. Please update the ChangeLog to give @vibraphon photograph credit for the vibraphone icon.

Copy link
Copy Markdown
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit.

Cross-checked completeness via some new tooling (will send a PR shortly):

$ ./tools/is-changelog-complete.sh 
Checking if all Github PRs since 3.8.1 are included for 3.8.2...
-> Missing PR #2249 (Added entries for all the changes since 3.8.1)
Checking if all Github Issues since 3.8.1 are included for 3.8.2...
-> Missing Issue #2247 (Prepare Release 3.8.2)
-> Missing Issue #2214 (Accelerator key collision in several languages)
Checking if all PR or Issue references in git log since r3_8_1 are included for 3.8.2 based on ref origin/master...
-> Missing PR #2221 from git log (Minor correction to PR template)
-> Missing PR #1993 from git log (Fix for #1688 - unicode in mixer should wrap on character boundaries)

#2214 should either be de-tagged or must be remembered for inclusion in the Changelog.
All other "findings" are not Changelog-worthy, so this is fine.

CHANGELOG: SKIP

Comment thread ChangeLog Outdated
@softins
Copy link
Copy Markdown
Member Author

softins commented Jan 20, 2022

@hoffie, thanks!

-> Missing Issue #2214 (Accelerator key collision in several languages)

#2214 should either be de-tagged or must be remembered for inclusion in the Changelog.

#2214 can only be addressed fully after the translation cycle. #2248 addressed it for English.

@softins
Copy link
Copy Markdown
Member Author

softins commented Jan 20, 2022

-> Missing PR #1993 from git log (Fix for #1688 - unicode in mixer should wrap on character boundaries)

Why is #1993 listed here? It was tagged for 3.8.1, not 3.8.2, but was actually closed, not merged, and replaced with #1994. Just thought it might be something to check in your tools.

@hoffie hoffie mentioned this pull request Jan 20, 2022
8 tasks
@softins softins merged commit 83d5f4f into jamulussoftware:master Jan 21, 2022
Comment thread ChangeLog
- Client: Added Vibraphone to list of instruments (#2043, #2080, #2158).
(contributed by @DavidSavinkoff, @softins, photo by @vibraphon)

- Client: On Windows, if no driver found while installing, the "Run Jamulus"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as this is an installer thing, can we also put the Mac client install fix below this? It's the main thing for Mac users in this release.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait it's merged - I'll do it myself :-)

@softins softins deleted the changelog-382 branch March 2, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants