Skip to content

[en] update footertext.md#260

Closed
trebmuh wants to merge 1 commit intoreleasefrom
issue-255
Closed

[en] update footertext.md#260
trebmuh wants to merge 1 commit intoreleasefrom
issue-255

Conversation

@trebmuh
Copy link
Copy Markdown
Member

@trebmuh trebmuh commented Jan 22, 2021

closes #255

@trebmuh trebmuh mentioned this pull request Jan 22, 2021


**Summer 2020! Tell us about Jamulus - [take our anonymous survey!](https://forms.gle/hSSjsxjWj2Pnp5kr7)**
**Tell us about Jamulus - [take our anonymous survey!](https://forms.gle/hSSjsxjWj2Pnp5kr7)**
Copy link
Copy Markdown
Member

@ann0see ann0see Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nevertheless, merging it to release instead of changes would violate the "typo fix only" policy. Translators would not be aware of this change. But I must admit, I've partly violated it with the new installer.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were doing something like a hook which automatically updated changes with modifications made to release?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way, done: 38511a3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But this doesn't include content which needs to be translated. So if you change something in french and merge it to release, it will also add the commit to changes. But obviously this isn't possible for multiple languages.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks for the explanation and sorry for the mistake here.

@trebmuh trebmuh closed this Jan 22, 2021
@trebmuh trebmuh deleted the issue-255 branch January 22, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants