Skip to content

[en] update footertext.md #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trebmuh wants to merge 1 commit into from
Closed

[en] update footertext.md #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/wiki/en/footertext.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@


**Summer 2020! Tell us about Jamulus - [take our anonymous survey!](https://forms.gle/hSSjsxjWj2Pnp5kr7)**
**Tell us about Jamulus - [take our anonymous survey!](https://forms.gle/hSSjsxjWj2Pnp5kr7)**
Copy link
Copy Markdown
Member

@ann0see ann0see Jan 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nevertheless, merging it to release instead of changes would violate the "typo fix only" policy. Translators would not be aware of this change. But I must admit, I've partly violated it with the new installer.

Copy link
Copy Markdown
Member Author

@trebmuh trebmuh Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were doing something like a hook which automatically updated changes with modifications made to release?

Copy link
Copy Markdown
Member Author

@trebmuh trebmuh Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way, done: 38511a3

Copy link
Copy Markdown
Member

@ann0see ann0see Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. But this doesn't include content which needs to be translated. So if you change something in french and merge it to release, it will also add the commit to changes. But obviously this isn't possible for multiple languages.

Copy link
Copy Markdown
Member Author

@trebmuh trebmuh Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks for the explanation and sorry for the mistake here.



_This documentation is licensed under a [Creative Commons License](https://creativecommons.org/licenses/by-sa/4.0/deed.en){: target="_blank" rel="noreferrer" }. Want to [contribute](Contribution)?_