Skip to content

Remove lang files while pausing translation#400

Merged
gilgongo merged 2 commits intoreleasefrom
lang-pause
Apr 5, 2021
Merged

Remove lang files while pausing translation#400
gilgongo merged 2 commits intoreleasefrom
lang-pause

Conversation

@gilgongo
Copy link
Copy Markdown
Member

@gilgongo gilgongo commented Mar 28, 2021

Does this need translation?

  • Yes
  • No

Changes

Remove for now as per the discussion here:
jamulussoftware/jamulus#1302 (comment)

Until further notice, we are only translating the following sections, apart for ES which continues to apply to all:

  • Homepage
  • Getting Started
  • Windows/Mac/Linux installation pages

@gilgongo gilgongo requested a review from ann0see March 28, 2021 15:00
@ann0see
Copy link
Copy Markdown
Member

ann0see commented Mar 28, 2021

Hmm. German is up to date too. So should we really remove all of them?

Tagging @dzpex @trebmuh here

@gilgongo
Copy link
Copy Markdown
Member Author

Sorry, I didn't get the message that DE was up to date, only ES. So far we have only had a commitment from @ignotus666 to keep the entire site up to date. I was under the impression that others would only be OK with the areas listed above.

If that's NOT the case, and people are volunteering to keep languages up to date for the entire site (in the face of possibly large and continuous changes to the English over time), then we need to get their agreement on that. Please review jamulussoftware/jamulus#1302 (comment) and the points made there about all this first though.

@ann0see
Copy link
Copy Markdown
Member

ann0see commented Mar 28, 2021

Maybe I need to clarify:

The German pages which exist now should all be up to date. However I didn’t translate all pages and would remove a bunch of them (especially contributing) which I doubt many people read. Same goes for the CLI page and the Central Server one. I‘ll soon review the other PRs, but unfortunately I currently don‘t have access to my PC

@gilgongo
Copy link
Copy Markdown
Member Author

Sure, so if you can add those files to DE for now. If they get out of date we can always remove them until they're OK.

Copy link
Copy Markdown
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to re-add them?

Comment thread wiki/de/de-Installation-for-Android.md
Comment thread wiki/de/de-Onboarding.md
Comment thread wiki/de/index.md
@gilgongo gilgongo self-assigned this Mar 29, 2021
Comment thread wiki/fr/fr-Onboarding.md
@gilgongo
Copy link
Copy Markdown
Member Author

gilgongo commented Apr 4, 2021

@ann0see Can you wait on Compiling.md until I've done my PR for #382 later today? It's a total re-write so I don't want to waste your time.

Overall though, is there some confusion about this ticket? The point of removing the files is to stop out-of-date and possibly misleading translations from appearing on the site, and to cut down on re-translation of stuff that's changing heavily in the English. If I were you, I'd remove the files and simply wait until the English settles down, otherwise we'll be going around in circles.

@gilgongo gilgongo dismissed ann0see’s stale review April 5, 2021 13:41

I think I've added them?

@gilgongo gilgongo merged commit 2acf651 into release Apr 5, 2021
@gilgongo gilgongo deleted the lang-pause branch April 5, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants