Skip to content

Update fr web translation for 3.9.0#780

Merged
ann0see merged 1 commit intojamulussoftware:next-releasefrom
jujudusud:next-release
Jul 16, 2022
Merged

Update fr web translation for 3.9.0#780
ann0see merged 1 commit intojamulussoftware:next-releasefrom
jujudusud:next-release

Conversation

@jujudusud
Copy link
Copy Markdown
Member

@jujudusud jujudusud commented Jul 13, 2022 •
edited
Loading

Short description of changes
Translation of the website in french.

Context: Fixes an issue? Related issues
Fixes: #776.

Status of this Pull Request
Waiting on team.

What is missing until this pull request can be merged?

  • All the po file are fully tranlsated,
  • verfiying the translation of links. French part after the #,
  • New screenshots needed and there url putted in the includes files).
  • Squashing all the commits in a unique one after the end of the review.

Does this need translation?
No.

Checklist

  • I've verified that this Pull Request follows the general code principles,
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors,
  • I'm sure that this Pull Request goes to the correct branch.

@ann0see ann0see added this to the Release 3.9.0 milestone Jul 13, 2022
@jujudusud jujudusud self-assigned this Jul 14, 2022
@jujudusud jujudusud added the translation Issue or PR releated to translation label Jul 14, 2022
trebmuh
trebmuh reviewed Jul 14, 2022
View reviewed changes
Comment thread _translator-files/po/fr/Installation-for-Windows.po
trebmuh
trebmuh reviewed Jul 14, 2022
View reviewed changes
Comment thread _translator-files/po/fr/Installation-for-Macintosh.po Outdated
trebmuh
trebmuh reviewed Jul 14, 2022
View reviewed changes
Comment thread _translator-files/po/fr/Installation-for-Macintosh.po Outdated
trebmuh
trebmuh previously requested changes Jul 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@trebmuh trebmuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread _translator-files/po/fr/Server-Bandwidth.po Outdated
Comment thread _translator-files/po/fr/Server-Bandwidth.po Outdated
@pljones pljones linked an issue Jul 15, 2022 that may be closed by this pull request
Update fr web translation for 3.9.0 #776
Closed
@jujudusud jujudusud marked this pull request as ready for review July 15, 2022 14:01
@jujudusud
Copy link
Copy Markdown
Member Author

jujudusud commented Jul 16, 2022

I will squash all the commits now.

@jujudusud
Update fr web translation for 3.9.0
f76b585 
more translations in fr website

two other po files translations in fr website

6 other po files translations in fr website

resolving trebmuh's first review

latest po file to be translated

new translated screenshots addresses in .inc files

resolving trebmuh's second review

typo, links in fr+ some forgotten strings
@pljones pljones dismissed trebmuh’s stale review July 16, 2022 16:36

I'm assuming you meant to sign this off as OK?

@ann0see ann0see merged commit 9ff934e into jamulussoftware:next-release Jul 16, 2022
@pljones pljones mentioned this pull request Jul 22, 2022
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trebmuh trebmuh trebmuh left review comments

@pljones pljones pljones approved these changes

Assignees

@jujudusud jujudusud

Labels

translation Issue or PR releated to translation

Projects

None yet

Milestone

Release 3.9.0

Development

Successfully merging this pull request may close these issues.

Update fr web translation for 3.9.0

4 participants

@jujudusud @pljones @trebmuh @ann0see