Skip to content

Make importlib_metadata optional on Python 3.10#576

Closed
tal66 wants to merge 1 commit into
jaraco:mainfrom
tal66:importlib-optional
Closed

Make importlib_metadata optional on Python 3.10#576
tal66 wants to merge 1 commit into
jaraco:mainfrom
tal66:importlib-optional

Conversation

@tal66
Copy link
Copy Markdown

@tal66 tal66 commented May 23, 2022

Hi, I think this will close #575.

Copy link
Copy Markdown
Collaborator

@mitya57 mitya57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update imports to use the standard library module if it's available, instead of the backport.

I.e. replace this

import importlib_metadata as metadata

with something like this

import sys

if sys.version_info >= (3, 10):
    from importlib import metadata
else:
    import importlib_metadata as metadata

@tal66
Copy link
Copy Markdown
Author

tal66 commented May 28, 2022

closing this, since I see you gave the same task to another PR with the same change, submitted 2 days after this one.
no need to have us both do this

@mitya57
Copy link
Copy Markdown
Collaborator

mitya57 commented May 28, 2022

I don't have a reason to prefer the other pull request over this one, or vice versa. I saw two similar pull requests, and left two similar comments.

The other pull request is still not ready yet — there are CI failures.

@tal66
Copy link
Copy Markdown
Author

tal66 commented May 28, 2022

i'm sure with your guidance he can pull this off. illogical to let us both spend time on this just to reject one. plus i don’t like the encouragement to submit a pr that someone else already started – i’d never do that even when I know better. cheers

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make importlib_metadata optional on Python 3.10.

2 participants