Changed importlib_metadata to have requirement for < python 3.10

[probro27]

Trying to fix the issue #575.
Hope it works!!

[mitya57]

Also please see what I wrote in this comment:
#576 (review)

[probro27]

I have updated the imports as per #576 (review)
Hope this works!

[probro27]

Hmm, any idea what might cause the tests to fail? I didn't change anything that could cause errors. I'll try to investigate. If you find anything, let me know!
Thanks!

[mitya57]

So mypy complains about this:

______________________________ keyring/backend.py ______________________________
15: error: Name "metadata" already defined (by an import)
___________________________ tests/test_packaging.py ____________________________
4: error: Name "metadata" already defined (by an import)

I would simply silence that. Try adding # type: ignore comments at the end of line 15 of keyring/backend.py and line 4 of tests/test_packaging.py.

Like this:

try:
    from importlib import metadata
except ImportError:
    import importlib_metadata as metadata  # type: ignore

[probro27]

Alright I have added that. Thanks for the help!
Let's hope it works now!

[mitya57]

I am sorry. It still doesn't work because Python 3.9 and earlier does have importlib.metadata available, although it does not support group argument, so we can't use it.

Let's try this:

import sys

if sys.version_info >= (3, 10):
    from importlib import metadata
else:
    import importlib_metadata as metadata

Add import sys

I hope # type: ignore won't be needed with this, but let's see.

[probro27]

I have added the # type:ignore on the imports for now, coz I was getting a linting error when I was not doing that. I hope this works!

[probro27]

_________________________________ FLAKE8-check _________________________________ /home/runner/work/keyring/keyring/tests/test_packaging.py:6:42: E261 at least two spaces before inline comment /home/runner/work/keyring/keyring/tests/test_packaging.py:6:43: E262 inline comment should start with '# '
Does this seem to be the error?

[mitya57]

Yes, you need two spaces before # and one space after #. And please remove commented out code.

[probro27]

Okay, I have changed the formatting and removed the comments.

[mitya57]

Yes, now CI finally passes. Thanks!

You have my approval, but let's wait for @jaraco who is the chief maintainer.

[jaraco]

I added a couple of nitpicky changes and a changelog, but this looks good. Thanks for pulling it together!

[probro27]

Thanks for merging it!
Glad to be of help :))