Fix a number of issues with pr253#258
Merged
mergify[bot] merged 6 commits intojd:masterfrom Oct 22, 2020
Merged
Conversation
…Tests fail Tests in TestInvokeViaLegacyCallMethod begin to fail. This reverts commit 8ee3d27
ivanprado
reviewed
Oct 21, 2020
| "Use 'Retrying.__call__()' instead") | ||
| self.__call__(self, *args, **kwargs) | ||
| "Use 'Retrying.__call__()' instead", DeprecationWarning) | ||
| return self.__call__(*args, **kwargs) |
Contributor
There was a problem hiding this comment.
Ops, what a big miss. Thank you for finding this!
jd
approved these changes
Oct 22, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrying.__call__()interface to demonstrate a number of issues with the changes from Make AsyncRetrying callable (as Retrying class) #253Retrynig.call()method:-self.__call__(self, ...)i.e. passing itself, the Retrying instance, as the function to call. Now that Retrying is callable, this sneaks in and leads to reentrant invocation of the same Retrying object (is that even supported?) and, ultimately nested retrying. Uber-badness; not caught by any existing tests! :-oUserWarningrather thanDeprecationWarningtype (which is what other parts of the code use for backward compatibility shims)This PR contains a number of commits that can and probably should be squashed into a single commit after review. Let me know if you want me to do this (I don't know how easy GitHub makes it for you to do this at merge-time, whilst letting you compose a sensible commit message).