Replace nap.sleep with a method to allow mocking after import

[asqui]

Fixes #228

[asqui]

Ok, I think this branch is ready to merge now.

[asqui]

@ivanprado : Fascinating failure when I merged your change 78a462e (#253) into this PR branch.

This PR makes a tweak to allow easier mocking of nap.sleep, but the test failures indicate that when using the Retrying.call() method (which is deprecated by your commit) sleep() is now getting called 24 times rather than 4.

I tweaked the test to invoke using __call__ (i.e. retrying(fn) rather than retrying.call(fn) in the spirit of your change) and this resolves the issue, but it suggests that something is very wrong with the backward compatibility for call() introduced by your commit.

Smells like we're getting nested layers of retrying, but I can't immediately see how or why that is happening. (Also, if that were the case I'd intuitively expect 4 x 4 = 16 retries, but seems we're getting 24 (= 4 x 6?) retries.)

This failure also hints we might want to (re-)introduce test coverage for the Retrying.call() method.

[ivanprado]

Wow. I have no idea what can be going on.

To give an idea, we might change this line 78a462e#diff-03f4d209c0b66034a81979dd67efaa24R435 by:

self(self, *args, **kwargs)

But in theory, it is completely equivalent. Could you try just in case it changes anything?

[asqui]

@ivanprado : The issue was that you are passing self as the first argument, which is meant to be the function to be executed by the retryer. That is, the retryer is going to execute itself, with retries!

PR #258 raised to resolve this.

[jd]

@Mergifyio update

[mergify]

Command update: success

Branch has been successfully updated

[asqui]

Tests are green again now.

Is there anything else required before this PR can be merged?