Add support for mocking sleep when retrying async functions#440
Closed
snorfalorpagus wants to merge 3 commits intojd:mainfrom
Closed
Add support for mocking sleep when retrying async functions#440snorfalorpagus wants to merge 3 commits intojd:mainfrom
snorfalorpagus wants to merge 3 commits intojd:mainfrom
Conversation
Contributor
|
|
jd
previously approved these changes
Feb 9, 2024
Author
|
@jd Let me know if there is anything else required before this can be merged. :) |
jd
approved these changes
Mar 2, 2024
|
It would be nice to see this get in soon. |
|
Any change for getting this in? |
Author
|
I don't have the energy to resolve conflicts on this as it's been sitting idle for so long without merge. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to mock sleeping when retrying asynchronous functions, using the same approach as was done for synchronous functions in #236.
Example usage:
Closes #360.