Use Octokit to generate installation access token#60
Conversation
|
This doesn't quite close #21; we still have This does output the following message to stderr, but I don't think that should be a problem: |
* Remove unused requires * Continue to use `installation` variable
I see. Can you please edit the issue to have "tasks" in it..? One each for |
|
I don't see a dedicated module to allow Octokit send requests to the Checks API, nor do I see an Issue / PR at the Octokit Repo to have one. So not sure what the best approach here would be. (FWIW, For my own test app, I was able to successfully patch Octokit to send requests to the Checks endpoints.) |
|
We haven’t updated Octokit yet for the new Checks API since it’s still in
beta. Your best bet is to make post calls directly with Octokit.
`Octokit.post` or similar should do the trick.
…On Fri, Jul 27, 2018 at 11:22 PM Ashwin Maroli ***@***.***> wrote:
I don't see a dedicated module to allow Octokit send requests to the
Checks API, nor do I see an Issue / PR at the Octokit Repo to have one. So
not sure what the best approach here would be.
/cc @parkr <https://github.com/parkr> @mattr- <https://github.com/mattr->
(FWIW, For my own test app, I was able to successfully patch Octokit to
send requests to the Checks endpoints.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#60 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEtdkv6Vo0K9pRblhgQ-0FcHAZwWnIUks5uK-cCgaJpZM4VkPAT>
.
|
Thank you @mattr-. I had a hunch that this would be the reason..
@pathawks Would having the following code in Utterson be welcome..? module Octokit
class Client
PREVIEW_HEADER = {
:headers => {
"Accept" => "application/vnd.github.antiope-preview+json"
}
}
def create_check_run(repo, data)
options = data.merge(PREVIEW_HEADER)
post "#{Repository.path repo}/check-runs", options
end
def update_check_run(repo, id, data)
options = data.merge(PREVIEW_HEADER)
patch "#{Repository.path repo}/check-runs/#{id}", options
end
end
end |
Octokit needs to be present on EC2 before the first time we run `bundle update`. Because of this, we need to install it with our install script. The Gemfile is just for running Jekyll, not API stuffs. /cc #60
Closes #21In theory, this should be all that's required, though I do not see how one can reliably test this..