Monkey patch Octokit::Client to access Checks API#61
Open
ashmaroli wants to merge 3 commits intojekyll:masterfrom
Open
Monkey patch Octokit::Client to access Checks API#61ashmaroli wants to merge 3 commits intojekyll:masterfrom
ashmaroli wants to merge 3 commits intojekyll:masterfrom
Conversation
mattr-
reviewed
Jul 30, 2018
Member
mattr-
left a comment
mattr-
left a comment
There was a problem hiding this comment.
Looks good with a couple of minor nits.
I'd like to see the file renamed to octokit_checks_api_patch.rb so it's more obvious from the filename what it is.
github/octokit_client_patch.rb
Outdated
| # https://developer.github.com/v3/checks/runs/#create-a-check-run | ||
| # ----------------------------------------------------------------------------------- | ||
| def create_check_run(repo, options) | ||
| post "#{Repository.path repo}/check-runs", options.merge(PREVIEW_HEADER) |
Member
There was a problem hiding this comment.
parenthesis please inside the interpolation
github/octokit_client_patch.rb
Outdated
| # https://developer.github.com/v3/checks/runs/#update-a-check-run | ||
| # ----------------------------------------------------------------------------------- | ||
| def update_check_run(repo, id, options) | ||
| patch "#{Repository.path repo}/check-runs/#{id}", options.merge(PREVIEW_HEADER) |
Member
There was a problem hiding this comment.
parenthesis please inside the interpolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of comments in #60
With this we temporarily enhance
Octokit::Clientto send requests to a couple of endpoints inthe Checks API.
Initial implementation
(Along similar lines as existing methods included within
Octokit::Client)name_with_ownerpattern as the first parameter instead of a URL.Sawyer::Resourceinstance) instead of a JSON payload currently sent./cc @mattr-