util::find() issue fixed

[Razdeep]

When linear scanning doesn't find the target element, the control must
not go back to the binary search logic.

Signed-off-by: Rajdeep Roy Chowdhury rrajdeeproychowdhury@gmail.com

[Razdeep]

In this line here, when pos = 0, the value of hi is changed to std::numeric_limits<uint64_t>::max() since the datatype is unsigned. Is there a better way to handle such scenarios?

[jermp]

Hi,
yes I think you are right. Indeed in the next_geq code below there is the break.
Can you check why the tests are failing then?
Thanks!

[jermp]

How about:
return global::not_found; instead of break and leave the code below unchanged? (It saves the if and the logic is cleaner.)

[Razdeep]

Returning global::not_found or breaking; both of them are failing the unit test.
However, if I keep only the if logic below, the unit test passes and takes care of the unsigned underflow bug too.

[jermp]

Oh yes, sorry the break of the return are just the same: I parsed one parenthesis less :)
Just setting hi = pos; and nothing else fixes the problem, without the if nor break.
Can you confirm this?

[Razdeep]

Setting hi = pos, introduces a potential infinity loop when pos is 0 and since the while loop condition is lo <= hi.
Changing the while condition from lo <= hi to lo < hi also breaks the unit tests.

[jermp]

Merged! Thanks.