Skip to content

util::find() issue fixed #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jermp merged 2 commits into from
Feb 8, 2022
Merged

util::find() issue fixed #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
622c4f7
fix: util::find() issue fixed
Razdeep Feb 7, 2022
84e7823
fix: unsigned underflow handled
Razdeep Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/util.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,17 @@ uint64_t find(S const& sequence, uint64_t id, uint64_t lo, uint64_t hi) {
return pos;
}
}
// break;
}
uint64_t pos = lo + ((hi - lo) >> 1);
uint64_t val = sequence.access(pos);
if (val == id) {
return pos;
} else if (val > id) {
// Rescuing hi from unsigned underflow
if (pos == 0) {
return global::not_found;
}
hi = pos - 1;
} else {
lo = pos + 1;
Expand Down