Skip to content

Using a single test262-harness.py for es5.1, es2015 and esnext. #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lygstate wants to merge 1 commit into from
Closed

Using a single test262-harness.py for es5.1, es2015 and esnext. #4389

lygstate wants to merge 1 commit into from

Conversation

@lygstate
Copy link
Contributor

@lygstate lygstate commented Dec 30, 2020 •
edited
Loading

Remove the need of tools/packaging/test262.py from test262 es5.1 branch.
This script are not running the tests in parallel; so we can getting the
es5.1 tests running faster.
And it's not compatible with python3. We can use a single test262-harness.py
to resolve compatibility problem.

This is a superset of #4379
And fixes #4384

Depends on:
#4378

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com

@lygstate lygstate force-pushed the remove-test262.py branch 10 times, most recently from 08a46ab to 22cf7be Compare December 30, 2020 14:58
@akosthekiss
Copy link
Member

akosthekiss commented Dec 30, 2020

It seems that this PR is (ab)used again to replace local/private testing. @lygstate please, explain what you are doing and why. You have been requested not to do this, i.e., not to flood the project's CI (or maintainers' mailbox). Otherwise, I'll suggest maintainers to auto-close these PRs without any review.

@lygstate
Copy link
Contributor Author

lygstate commented Dec 30, 2020 •
edited
Loading

It seems that this PR is (ab)used again to replace local/private testing. @lygstate please, explain what you are doing and why. You have been requested not to do this, i.e., not to flood the project's CI (or maintainers' mailbox). Otherwise, I'll suggest maintainers to auto-close these PRs without any review.

Sorry for the disturb, I'll be carefull next time, this pull request depends two other pull request, and that worried me.

@ossy-szeged ossy-szeged mentioned this pull request Dec 30, 2020
Closed
@lygstate lygstate force-pushed the remove-test262.py branch 3 times, most recently from b61a1ea to 2c86cd7 Compare January 13, 2021 04:06
@lygstate lygstate force-pushed the remove-test262.py branch 5 times, most recently from 67ce629 to 1241453 Compare January 18, 2021 08:23
@lygstate
Copy link
Contributor Author

lygstate commented Jan 18, 2021

@akosthekiss ready to review.

rerobika
rerobika reviewed Jan 18, 2021
View reviewed changes
@lygstate lygstate force-pushed the remove-test262.py branch 2 times, most recently from 8c5d5ae to b66e99e Compare January 18, 2021 16:13
rerobika
rerobika reviewed Jan 18, 2021
View reviewed changes
@rerobika rerobika added the tools Related to the tooling scripts label Jan 18, 2021
@lygstate lygstate requested a review from rerobika January 20, 2021 09:34
@lygstate
Copy link
Contributor Author

lygstate commented Jan 20, 2021

@akosthekiss please take a look

@lygstate
Copy link
Contributor Author

lygstate commented Jan 20, 2021

@ossy-szeged May have time to review this?

akosthekiss
akosthekiss requested changes Jan 21, 2021
View reviewed changes
@lygstate lygstate force-pushed the remove-test262.py branch 3 times, most recently from 6395c4d to 89c96e3 Compare January 23, 2021 03:47
@rerobika rerobika requested a review from akosthekiss February 4, 2021 12:43
@ossy-szeged ossy-szeged mentioned this pull request Feb 4, 2021
Merged
@lygstate lygstate requested a review from ossy-szeged February 9, 2021 05:13
@lygstate
Copy link
Contributor Author

lygstate commented Feb 9, 2021

ping for merge

@lygstate lygstate force-pushed the remove-test262.py branch 3 times, most recently from 6331814 to 80eaf81 Compare February 9, 2021 16:23
@lygstate
Using a single test262-harness.py for es5.1, es2015 and esnext.
06d01e4 
Remove the need of tools/packaging/test262.py from test262 es5.1 branch.
This script are not running the tests in parallel; so we can getting the
es5.1 tests running faster.
And it's not compatible with python3. We can use a single test262-harness.py
to resolve compatibility problem.

unmarked_default default to non_strict to match tools/packaging/test262.py
Handling negative for es51 differently.

For es5.1, the timeout should be None for waiting case finish with infinitely time

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@lygstate
Copy link
Contributor Author

lygstate commented Mar 29, 2021

can this be merged now?

@lygstate lygstate closed this Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rerobika rerobika rerobika approved these changes

@akosthekiss akosthekiss Awaiting requested review from akosthekiss

@ossy-szeged ossy-szeged Awaiting requested review from ossy-szeged

Assignees

No one assigned

Labels

tools Related to the tooling scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test262 are not match unix testing result on windows

4 participants

@lygstate @akosthekiss @ossy-szeged @rerobika