Skip to content

Conversation

@lygstate
Copy link
Contributor

When testing jerryscript on new platform, there maybe es5.1 test failure to tracking, so enable es5.1 excludelist option.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com

@ossy-szeged
Copy link
Contributor

It can be useful once we merged #4389. (the old harness doesn't support excludelist at all).
If we have ES5.1 excludelist, we should remove this hack too:
https://github.com/jerryscript-project/jerryscript/blob/master/tools/runners/run-test-suite-test262.py#L91

@lygstate lygstate force-pushed the es5.1-update branch 4 times, most recently from 6f8ead2 to 3538444 Compare January 6, 2021 12:07
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 12, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60 to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 12, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60 to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 12, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 30s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 13, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 13, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 14, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate added a commit to lygstate/jerryscript that referenced this pull request Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool.

The timeout error are like the following things:

```
C:\Users\lygstate>timeout -version
Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds.

C:\Users\lygstate>timeout 0 python
Error: invalid syntax. The default option does not allow more than '1' times.
Type "TIMEOUT /?" to learn how to use it.
```

timeout option are added for future ES5.1 test262 usage
in pull request
jerryscript-project#4391

The timeout setting to 60s to getting maximal tolerance
By doing this also fixes tests for es2015:
built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js
built-ins/decodeURI/S15.1.3.1_A2.5_T1.js

And also makes the debug build version of jerryscript can pass tests.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@lygstate lygstate force-pushed the es5.1-update branch 3 times, most recently from df35b1a to 0ab58f2 Compare January 17, 2021 13:15
Remove the need of tools/packaging/test262.py from test262 es5.1 branch.
This script are not running the tests in parallel; so we can getting the
es5.1 tests running faster.
And it's not compatible with python3. We can use a single test262-harness.py
to resolve compatibility problem.

unmarked_default default to non_strict to match tools/packaging/test262.py
Handling negative for es51 differently.

For es5.1, the timeout should be None for waiting case finish with infinitely time

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
When testing jerryscript on new platform, there maybe es5.1 test failure to tracking, so enable es5.1 excludelist option.
And also there is no need remove 'bestPractice' and 'intl402' test dirs in test262.

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@lygstate
Copy link
Contributor Author

lygstate commented Feb 9, 2021

Close in favor of #4389

@lygstate lygstate closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants