-
Notifications
You must be signed in to change notification settings - Fork 691
Make es5.1 option consistence with es2015 and esnext #4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It can be useful once we merged #4389. (the old harness doesn't support excludelist at all). |
6f8ead2 to
3538444
Compare
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 12, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60 to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
3538444 to
0e4c1c7
Compare
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 12, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60 to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 12, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 30s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 13, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
0e4c1c7 to
2c9f553
Compare
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 13, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 14, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
lygstate
added a commit
to lygstate/jerryscript
that referenced
this pull request
Jan 15, 2021
Use the platform independent python threading.Timer instead of the unix only timeout tool. The timeout error are like the following things: ``` C:\Users\lygstate>timeout -version Error: The specified timeout (/T) value is invalid. The valid range is from -1 to 99999 seconds. C:\Users\lygstate>timeout 0 python Error: invalid syntax. The default option does not allow more than '1' times. Type "TIMEOUT /?" to learn how to use it. ``` timeout option are added for future ES5.1 test262 usage in pull request jerryscript-project#4391 The timeout setting to 60s to getting maximal tolerance By doing this also fixes tests for es2015: built-ins/decodeURIComponent/S15.1.3.2_A2.5_T1.js built-ins/decodeURI/S15.1.3.1_A2.5_T1.js And also makes the debug build version of jerryscript can pass tests. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
df35b1a to
0ab58f2
Compare
0ab58f2 to
da49abd
Compare
Remove the need of tools/packaging/test262.py from test262 es5.1 branch. This script are not running the tests in parallel; so we can getting the es5.1 tests running faster. And it's not compatible with python3. We can use a single test262-harness.py to resolve compatibility problem. unmarked_default default to non_strict to match tools/packaging/test262.py Handling negative for es51 differently. For es5.1, the timeout should be None for waiting case finish with infinitely time JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
When testing jerryscript on new platform, there maybe es5.1 test failure to tracking, so enable es5.1 excludelist option. And also there is no need remove 'bestPractice' and 'intl402' test dirs in test262. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
da49abd to
8293b50
Compare
Contributor
Author
|
Close in favor of #4389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing jerryscript on new platform, there maybe es5.1 test failure to tracking, so enable es5.1 excludelist option.
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com