Add --build-debug options for run-tests.py script. #4456
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,59 +58,44 @@ def skip_if(condition, desc): | |
| JERRY_UNITTESTS_OPTIONS = [ | ||
| Options('unittests-es.next', | ||
| OPTIONS_COMMON + OPTIONS_UNITTESTS + OPTIONS_PROFILE_ESNEXT), | ||
| Options('doctests-es.next', | ||
| OPTIONS_COMMON + OPTIONS_DOCTESTS + OPTIONS_PROFILE_ESNEXT), | ||
| Options('unittests-es5.1', | ||
| OPTIONS_COMMON + OPTIONS_UNITTESTS + OPTIONS_PROFILE_ES51), | ||
| Options('doctests-es5.1', | ||
| OPTIONS_COMMON + OPTIONS_DOCTESTS + OPTIONS_PROFILE_ES51), | ||
| Options('unittests-es5.1-init-fini', | ||
| OPTIONS_COMMON + OPTIONS_UNITTESTS + OPTIONS_PROFILE_ES51 | ||
| + ['--cmake-param=-DFEATURE_INIT_FINI=ON'], | ||
| skip=skip_if((sys.platform == 'win32'), 'FEATURE_INIT_FINI build flag isn\'t supported on Windows,' + | ||
| ' because Microsoft Visual C/C++ Compiler doesn\'t support' + | ||
| ' library constructors and destructors.')), | ||
| Options('unittests-es5.1-math', | ||
| OPTIONS_COMMON + OPTIONS_UNITTESTS + OPTIONS_PROFILE_ES51 | ||
| + ['--jerry-math=on']), | ||
| ] | ||
|
|
||
| # Test options for jerry-tests | ||
| JERRY_TESTS_OPTIONS = [ | ||
| Options('jerry_tests-es.next', | ||
|
Contributor
Author
There was a problem hiding this comment. @ossy-szeged Hi, it's this build configuration.
Contributor
There was a problem hiding this comment. Ah, good to know that we haven't run esnext release jerry tests on the CI ever. Bad news.
Contributor
Author
There was a problem hiding this comment. Oh, I was think it's leaved not running intentionally |
||
| OPTIONS_COMMON + OPTIONS_PROFILE_ESNEXT + OPTIONS_STACK_LIMIT + OPTIONS_GC_MARK_LIMIT | ||
| + OPTIONS_MEM_STRESS), | ||
| Options('jerry_tests-es5.1', | ||
| OPTIONS_COMMON + OPTIONS_PROFILE_ES51 + OPTIONS_STACK_LIMIT + OPTIONS_GC_MARK_LIMIT), | ||
| Options('jerry_tests-es5.1-snapshot', | ||
| OPTIONS_COMMON + OPTIONS_PROFILE_ES51 + OPTIONS_SNAPSHOT + OPTIONS_STACK_LIMIT + OPTIONS_GC_MARK_LIMIT, | ||
| ['--snapshot']), | ||
| Options('jerry_tests-es5.1-cpointer_32bit', | ||
| OPTIONS_COMMON + OPTIONS_PROFILE_ES51 + OPTIONS_STACK_LIMIT + OPTIONS_GC_MARK_LIMIT | ||
| + ['--cpointer-32bit=on', '--mem-heap=1024']), | ||
| Options('jerry_tests-es5.1-external_context', | ||
| OPTIONS_COMMON + OPTIONS_PROFILE_ES51 + OPTIONS_STACK_LIMIT + OPTIONS_GC_MARK_LIMIT | ||
| + ['--external-context=on']), | ||
| ] | ||
|
|
||
| # Test options for test262 | ||
| TEST262_TEST_SUITE_OPTIONS = [ | ||
| Options('test262_tests', OPTIONS_PROFILE_ES51), | ||
| ] | ||
|
|
||
| # Test options for test262-es2015 | ||
|
|
@@ -127,7 +112,7 @@ def skip_if(condition, desc): | |
| # Test options for jerry-debugger | ||
| DEBUGGER_TEST_OPTIONS = [ | ||
| Options('jerry_debugger_tests', | ||
| ['--jerry-debugger=on']) | ||
| ] | ||
|
|
||
| # Test options for buildoption-test | ||
|
|
@@ -207,6 +192,8 @@ def get_arguments(): | |
| help='Run license check') | ||
| parser.add_argument('--check-magic-strings', action='store_true', | ||
| help='Run "magic string source code generator should be executed" check') | ||
| parser.add_argument('--build-debug', action='store_true', | ||
| help='Build debug version jerryscript') | ||
| parser.add_argument('--jerry-debugger', action='store_true', | ||
| help='Run jerry-debugger tests') | ||
| parser.add_argument('--jerry-tests', action='store_true', | ||
|
|
@@ -266,6 +253,10 @@ def report_skip(job): | |
|
|
||
| def create_binary(job, options): | ||
| build_args = job.build_args[:] | ||
| build_dir_path = os.path.join(options.outdir, job.name) | ||
| if options.build_debug: | ||
| build_args.extend(OPTIONS_DEBUG) | ||
| build_dir_path = os.path.join(options.outdir, job.name + '-debug') | ||
| if options.buildoptions: | ||
| for option in options.buildoptions.split(','): | ||
| if option not in build_args: | ||
|
|
@@ -275,7 +266,6 @@ def create_binary(job, options): | |
| build_cmd.append(settings.BUILD_SCRIPT) | ||
| build_cmd.extend(build_args) | ||
|
|
||
| build_cmd.append('--builddir=%s' % build_dir_path) | ||
|
|
||
| install_dir_path = os.path.join(build_dir_path, 'local') | ||
|
|
@@ -472,7 +462,7 @@ def run_unittests(options): | |
| break | ||
|
|
||
| if sys.platform == 'win32': | ||
| if options.build_debug: | ||
| build_config = "Debug" | ||
| else: | ||
| build_config = "MinSizeRel" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,7 +67,7 @@ | |
|
|
||
|
|
||
| # The timeout of each test case | ||
| TEST262_CASE_TIMEOUT = 180 | ||
|
|
||
|
|
||
| def yaml_load(string): | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now each job takes almost 2 times longer, since it's running the tests in release and debug mode.
I'd suggest to create <original_job_name>_Debug` jobs instead of burden each job with running it in debug mode as well. GH action can run 20 jobs in parallel so take it as an advantage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jerryscript-project/jerryscript/runs/1832072314?check_suite_focus=true
This is the test result, which test need split?
Or all need to be split?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jerryscript-project/jerryscript/runs/1832072314?check_suite_focus=true This already consume 12minutes.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, most of them are okay within one job, but I'd definitely split these:
These show the biggest slowdowns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4389 fixes ES5_1, others OK to me