feat: enable volumes and volumeMounts to be passed to the jetstack-agent deployment#540
Merged
feat: enable volumes and volumeMounts to be passed to the jetstack-agent deployment#540
Conversation
…ent deployment Signed-off-by: Peter <peter.fiddes@gmail.com>
aidy
reviewed
Jun 20, 2024
aidy
reviewed
Jun 20, 2024
Signed-off-by: Peter <peter.fiddes@gmail.com>
Member
Author
|
@aidy thank you, have corrected those now. Can you cast one more eye over the changes please? |
aidy
approved these changes
Jun 20, 2024
aidy
left a comment
aidy
left a comment
There was a problem hiding this comment.
lgtm, although we should probably also bring these changes into the venafi agent chart.
Member
Author
Agreed, but I don't have a CTA for that, and it doesn't help the customer problem I have. So I'll drop that as an issue for now. #541 |
maelvls
reviewed
Jun 27, 2024
| - name: cabundle | ||
| configmap: | ||
| name: cabundle | ||
| optional: true |
Member
There was a problem hiding this comment.
Why is this optional? Isn't this prone to silent unexpected situations such as you forget to create the CA bundle configmap and the pod somehow isn't able to connect?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working with a customer and needed to pass a configmap mount to the deployment.
This is not currently available in the chart.
This PR adds this capability in a generic way, similar to how it is done in the cert-manager chart.
I have specifically not created a new release of the chart. I intend to do a simple followup PR to release 0.3.2.