Skip to content

chore: Upgrade chart version to 0.4.0 for jetstack-agent#542

Merged
hawksight merged 1 commit intomasterfrom
jetstack-agent-0-3-2
Jun 28, 2024
Merged

chore: Upgrade chart version to 0.4.0 for jetstack-agent#542
hawksight merged 1 commit intomasterfrom
jetstack-agent-0-3-2

Conversation

@hawksight
Copy link
Member

Bump minor version to release the chart change to be able to add Volumes & VolumeMounts from #540.

@hawksight hawksight force-pushed the jetstack-agent-0-3-2 branch from 99e6d70 to c5b0372 Compare June 20, 2024 16:21
@hawksight hawksight requested review from SpectralHiss and aidy June 20, 2024 16:26
description: TLS Protect for Kubernetes Agent
type: application
version: 0.3.1
version: 0.3.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bumping the hotfix/patch version, not the minor version.

imo, this should be a minor version (0.4.0), but if you've already cut a 0.3.2 release, or if you really want it to be 0.3.2, I'm not feeling particularly pedantic today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm easy. I have not cut a release (create from master manually after merging).
Minor encompases new features correct?
Patch is just fixing existing features?

Happy to change to keep this right, just checking it is right.

Signed-off-by: Peter <peter.fiddes@gmail.com>
@hawksight hawksight force-pushed the jetstack-agent-0-3-2 branch from c5b0372 to 084763a Compare June 28, 2024 15:12
@hawksight hawksight changed the title chore: Upgrade chart version to 0.3.2 for jetstack-agent chore: Upgrade chart version to 0.4.0 for jetstack-agent Jun 28, 2024
@hawksight hawksight merged commit 11df52b into master Jun 28, 2024
@hawksight hawksight deleted the jetstack-agent-0-3-2 branch June 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants