Skip to content

Comments

Add Camera.software_version Nest API#155

Merged
awarecan merged 2 commits intomasterfrom
camera-sw-version
Oct 22, 2018
Merged

Add Camera.software_version Nest API#155
awarecan merged 2 commits intomasterfrom
camera-sw-version

Conversation

@awarecan
Copy link
Collaborator

Camera.software_version can get from Nest API
https://developers.nest.com/reference/api-camera#software_version

@schmittx
Copy link
Collaborator

schmittx commented Oct 17, 2018

Technically OK, but what do you think about moving software_version to the Device class for simplicity, since all devices support it? Similar to online.

@schmittx schmittx closed this Oct 22, 2018
@schmittx schmittx reopened this Oct 22, 2018
@schmittx schmittx closed this Oct 22, 2018
@schmittx schmittx reopened this Oct 22, 2018
@awarecan awarecan changed the title Camera.software_version can get from Nest API Add Camera.software_version Nest API Oct 22, 2018
@awarecan awarecan merged commit 6b49b7f into master Oct 22, 2018
@schmittx
Copy link
Collaborator

Sorry for all of the closing/reopening, GitHub.com wasn't updating due to the server problems.

@awarecan awarecan deleted the camera-sw-version branch October 22, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants