Skip to content

Add Camera.software_version Nest API #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awarecan merged 2 commits into from
Oct 22, 2018
Merged

Add Camera.software_version Nest API #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3edc4
Camera.software_version can get from Nest API
awarecan Sep 25, 2018
436b7ef
Move software_version to Device object
schmittx Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions nest/nest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,10 @@ def device_id(self):
def online(self):
return self._device.get('is_online')

@property
def software_version(self):
return self._device.get('software_version')

@property
def structure(self):
if 'structure_id' in self._device:
Expand Down Expand Up @@ -336,10 +340,6 @@ def _track(self):
raise NotImplementedError("Deprecated Nest API")
# return self._nest_api._status['track'][self._serial]

@property
def software_version(self):
return self._device.get('software_version')

@property
def fan(self):
# FIXME confirm this is the same as old havac_fan_state
Expand Down Expand Up @@ -920,10 +920,6 @@ def smoke_sequence_number(self):
def smoke_status(self):
return self._device.get('smoke_alarm_state')

@property
def software_version(self):
return self._device.get('software_version')

@property
def spoken_where_id(self):
raise NotImplementedError("No longer available in Nest API")
Expand Down Expand Up @@ -1301,11 +1297,6 @@ def resource_id(self):
raise NotImplementedError("No longer available in Nest API")
# return self._device['resource_id']

@property
def software_version(self):
raise NotImplementedError("No longer available in Nest API")
# return self._device['software_version']

@property
def spoken_where_id(self):
raise NotImplementedError("No longer available in Nest API")
Expand Down