Fix TaskerPluginRunner always using default NotificationProperties #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwh
commented
Sep 13, 2021
| } | ||
|
|
||
| @TargetApi(Build.VERSION_CODES.O) | ||
| fun startForegroundIfNeeded(intentServiceParallel: IntentServiceParallel) { |
Contributor
Author
There was a problem hiding this comment.
I did not use an extension function here as it would clash with IntentServiceParallel.startForegroundIfNeeded
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskerPluginRunerActionis always callingIntentServiceParallel.startForegroundIfNeededwhich callsTaskerPluginRunner.startForegroundIfNeeded(this), which will always use the default value ofNotificationProperties.This fix adds
TaskerPluginRunner.startForegroundIfNeeded(intentServiceParallel: IntentServiceParallel), which is called fromTaskerPluginRunnerActionto properly use the configuredNotificationProperties.Before: Notification icon is not displayed properly even though it is configured
After: Notification icon is displayed properly:
